We shouldn't update data here and we should redraw on the main thread

shana · shana · commit ad23dcd042c2 · 2018-06-01T21:16:44.000+02:00
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs
@@ -212,6 +212,7 @@ private void ValidateCachedData(IRepository repository)
         private void MaybeUpdateData()
         {
             connection = Platform.Keychain.Connections.FirstOrDefault();
+
             if (repositoryProgressHasUpdate)
             {
                 if (repositoryProgress != null)
@@ -425,8 +426,10 @@ private void ApplicationManagerOnProgress(IProgress progress)
 
         private void ConnectionsChanged()
         {
-            connection = Platform.Keychain.Connections.FirstOrDefault();
-            Redraw();
+            if (!ThreadingHelper.InUIThread)
+                TaskManager.RunInUI(Redraw);
+            else
+                Redraw();
         }
 
         public override void OnUI()

Original file line number	Diff line number	Diff line change
`@@ -212,6 +212,7 @@ private void ValidateCachedData(IRepository repository)`
`212`	`212`	`private void MaybeUpdateData()`
`213`	`213`	`{`
`214`	`214`	`connection = Platform.Keychain.Connections.FirstOrDefault();`
	`215`	`+`
`215`	`216`	`if (repositoryProgressHasUpdate)`
`216`	`217`	`{`
`217`	`218`	`if (repositoryProgress != null)`
`@@ -425,8 +426,10 @@ private void ApplicationManagerOnProgress(IProgress progress)`
`425`	`426`
`426`	`427`	`private void ConnectionsChanged()`
`427`	`428`	`{`
`428`		`- connection = Platform.Keychain.Connections.FirstOrDefault();`
`429`		`- Redraw();`
	`429`	`+ if (!ThreadingHelper.InUIThread)`
	`430`	`+ TaskManager.RunInUI(Redraw);`
	`431`	`+ else`
	`432`	`+ Redraw();`
`430`	`433`	`}`
`431`	`434`
`432`	`435`	`public override void OnUI()`