Merge pull request #733 from github-for-unity/fixes/dont-fail-if-updates-are-not-available

StanleyGoldman · web-flow · commit af0451e2dc3c · 2018-05-11T17:57:05.000-04:00
Don't throw errors if we can't download the latest json feed
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UpdateCheck.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UpdateCheck.cs
@@ -60,7 +60,8 @@ public class UpdateCheckWindow :  EditorWindow
 
         public static void CheckForUpdates()
         {
-            var download = new DownloadTask(TaskManager.Instance.Token, EntryPoint.Environment.FileSystem, UpdateFeedUrl, EntryPoint.Environment.UserCachePath);
+            var download = new DownloadTask(TaskManager.Instance.Token, EntryPoint.Environment.FileSystem, UpdateFeedUrl, EntryPoint.Environment.UserCachePath)
+                .Catch(e => true);
             download.OnEnd += (thisTask, result, success, exception) =>
             {
                 if (success)

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,8 @@ public class UpdateCheckWindow : EditorWindow`
`60`	`60`
`61`	`61`	`public static void CheckForUpdates()`
`62`	`62`	`{`
`63`		`- var download = new DownloadTask(TaskManager.Instance.Token, EntryPoint.Environment.FileSystem, UpdateFeedUrl, EntryPoint.Environment.UserCachePath);`
	`63`	`+ var download = new DownloadTask(TaskManager.Instance.Token, EntryPoint.Environment.FileSystem, UpdateFeedUrl, EntryPoint.Environment.UserCachePath)`
	`64`	`+ .Catch(e => true);`
`64`	`65`	`download.OnEnd += (thisTask, result, success, exception) =>`
`65`	`66`	`{`
`66`	`67`	`if (success)`