Use setters instead of virtual properties

Author: shana

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/AuthenticationView.cs

@@ -7,18 +7,18 @@ namespace GitHub.Unity
     [Serializable]
     class AuthenticationView : Subview
     {
-        private static readonly Vector2 PublishViewSize = new Vector2(290, 290);
-
-        const string WindowTitle = "Authenticate";
-        const string UsernameLabel = "Username";
-        const string PasswordLabel = "Password";
-        const string TwofaLabel = "2FA Code";
-        const string LoginButton = "Sign in";
-        const string BackButton = "Back";
-        const string AuthTitle = "Sign in to GitHub";
-        const string TwofaTitle = "Two-Factor Authentication";
-        const string TwofaDescription = "Open the two-factor authentication app on your device to view your 2FA code and verify your identity.";
-        const string TwofaButton = "Verify";
+        private static readonly Vector2 viewSize = new Vector2(290, 290);
+
+        private const string WindowTitle = "Authenticate";
+        private const string UsernameLabel = "Username";
+        private const string PasswordLabel = "Password";
+        private const string TwofaLabel = "2FA Code";
+        private const string LoginButton = "Sign in";
+        private const string BackButton = "Back";
+        private const string AuthTitle = "Sign in to GitHub";
+        private const string TwofaTitle = "Two-Factor Authentication";
+        private const string TwofaDescription = "Open the two-factor authentication app on your device to view your 2FA code and verify your identity.";
+        private const string TwofaButton = "Verify";
 
         [SerializeField] private Vector2 scroll;
         [SerializeField] private string username = "";
@@ -62,6 +62,8 @@ public override void InitializeView(IView parent)
         {
             base.InitializeView(parent);
             need2fa = busy = false;
+            Title = WindowTitle;
+            Size = viewSize;
         }
 
         public override void OnEnable()
@@ -246,15 +248,5 @@ private void ShowErrorMessage()
                 GUILayout.Label(errorMessage, Styles.ErrorLabel);
             }
         }
-
-        public override string Title
-        {
-            get { return WindowTitle; }
-        }
-
-        public override Vector2 Size
-        {
-            get { return PublishViewSize; }
-        }
     }
 }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BaseWindow.cs

@@ -124,7 +124,7 @@ public virtual void OnDestroy()
         public virtual void OnSelectionChange()
         {}
 
-        public virtual Rect Position { get { return position; } }
+        public Rect Position { get { return position; } }
         public IApplicationManager Manager { get; private set; }
         public IRepository Repository { get { return inLayout ? cachedRepository : Environment.Repository; } }
         public bool HasRepository { get { return Environment.RepositoryPath != null; } }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PublishView.cs

@@ -8,7 +8,7 @@ namespace GitHub.Unity
 {
     class PublishView : Subview
     {
-        private static readonly Vector2 PublishViewSize = new Vector2(300, 250);
+        private static readonly Vector2 viewSize = new Vector2(300, 250);
 
         private const string WindowTitle = "Publish";
         private const string Header = "Publish this repository to GitHub";
@@ -54,6 +54,8 @@ public IApiClient Client
         public override void InitializeView(IView parent)
         {
             base.InitializeView(parent);
+            Title = WindowTitle;
+            Size = viewSize;
             PopulateView();
         }
 
@@ -236,15 +238,5 @@ public override void OnGUI()
             GUILayout.EndHorizontal();
             GUILayout.Space(10);
         }
-
-        public override string Title
-        {
-            get { return WindowTitle; }
-        }
-
-        public override Vector2 Size
-        {
-            get { return PublishViewSize; }
-        }
     }
 }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Subview.cs

@@ -53,10 +53,6 @@ public virtual void Finish(bool result)
         public virtual void OnRepositoryChanged(IRepository oldRepository)
         {}
 
-        public virtual string Title { get { return null; } }
-
-        public virtual Vector2 Size { get { return Vector2.zero; } }
-
         protected IView Parent { get; private set; }
         public IApplicationManager Manager { get { return Parent.Manager; } }
         public IRepository Repository { get { return Parent.Repository; } }
@@ -66,7 +62,9 @@ public virtual void OnRepositoryChanged(IRepository oldRepository)
         protected IGitClient GitClient { get { return Manager.GitClient; } }
         protected IEnvironment Environment { get { return Manager.Environment; } }
         protected IPlatform Platform { get { return Manager.Platform; } }
-        public virtual Rect Position { get { return Parent.Position; } }
+        public Rect Position { get { return Parent.Position; } }
+        public string Title { get; protected set; }
+        public Vector2 Size { get; protected set; }
 
         private ILogging logger;
         protected ILogging Logger