Escape command options

StanleyGoldman · StanleyGoldman · commit b6343185c9d9 · 2018-03-09T09:32:43.000-05:00
diff --git a/src/GitHub.Api/Application/ApiClient.cs b/src/GitHub.Api/Application/ApiClient.cs
@@ -213,19 +213,22 @@ private async Task<GitHubRepository> CreateRepositoryInternal(NewRepository newR
                 var uriString = keychain.Connections.First().Host;
                 var keychainAdapter = await keychain.Load(uriString);
 
-                var command = new StringBuilder("publish -r ");
+                var command = new StringBuilder("publish -r \"");
                 command.Append(newRepository.Name);
+                command.Append("\"");
 
                 if (!string.IsNullOrEmpty(newRepository.Description))
                 {
-                    command.Append(" -d ");
+                    command.Append(" -d \"");
                     command.Append(newRepository.Description);
+                    command.Append("\"");
                 }
 
                 if (!string.IsNullOrEmpty(organization))
                 {
-                    command.Append(" -o ");
+                    command.Append(" -o \"");
                     command.Append(organization);
+                    command.Append("\"");
                 }
 
                 if (newRepository.Private ?? false)

Original file line number	Diff line number	Diff line change
`@@ -213,19 +213,22 @@ private async Task<GitHubRepository> CreateRepositoryInternal(NewRepository newR`
`213`	`213`	`var uriString = keychain.Connections.First().Host;`
`214`	`214`	`var keychainAdapter = await keychain.Load(uriString);`
`215`	`215`
`216`		`- var command = new StringBuilder("publish -r ");`
	`216`	`+ var command = new StringBuilder("publish -r \"");`
`217`	`217`	`command.Append(newRepository.Name);`
	`218`	`+ command.Append("\"");`
`218`	`219`
`219`	`220`	`if (!string.IsNullOrEmpty(newRepository.Description))`
`220`	`221`	`{`
`221`		`- command.Append(" -d ");`
	`222`	`+ command.Append(" -d \"");`
`222`	`223`	`command.Append(newRepository.Description);`
	`224`	`+ command.Append("\"");`
`223`	`225`	`}`
`224`	`226`
`225`	`227`	`if (!string.IsNullOrEmpty(organization))`
`226`	`228`	`{`
`227`		`- command.Append(" -o ");`
	`229`	`+ command.Append(" -o \"");`
`228`	`230`	`command.Append(organization);`
	`231`	`+ command.Append("\"");`
`229`	`232`	`}`
`230`	`233`
`231`	`234`	`if (newRepository.Private ?? false)`