Enable delete button based on selected branch state

donokuda · shana · commit bcca94087674 · 2017-06-26T13:25:02.000+02:00
Not perfect yet
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BranchesView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BranchesView.cs
@@ -436,10 +436,16 @@ private void OnCreateGUI()
             // Create button
             if (mode == BranchesMode.Default)
             {
+                // If the current branch is selected, then do not enable the Delete button
+                GUI.enabled = activeBranchNode != selectedNode;
                 if (GUILayout.Button("Delete", EditorStyles.miniButton, GUILayout.ExpandWidth(false)))
                 {
-                    EditorUtility.DisplayDialog("Delete Branch?", "Are you sure you want to delete the branch: BRANCHNAME", "Delete", "Cancel");
+                    var selectedBranchName = selectedNode.Name;
+                    var dialogTitle = "Delete Branch: " + selectedBranchName;
+                    var dialogMessage = "Are you sure you want to delete the branch: " + selectedBranchName + "?";
+                    EditorUtility.DisplayDialog("Delete Branch?", dialogMessage, "Delete", "Cancel");
                 }
+                GUI.enabled = true;
                 GUILayout.FlexibleSpace();
                 if (GUILayout.Button(CreateBranchButton, EditorStyles.miniButton, GUILayout.ExpandWidth(false)))
                 {

Original file line number	Diff line number	Diff line change
`@@ -436,10 +436,16 @@ private void OnCreateGUI()`
`436`	`436`	`// Create button`
`437`	`437`	`if (mode == BranchesMode.Default)`
`438`	`438`	`{`
	`439`	`+ // If the current branch is selected, then do not enable the Delete button`
	`440`	`+ GUI.enabled = activeBranchNode != selectedNode;`
`439`	`441`	`if (GUILayout.Button("Delete", EditorStyles.miniButton, GUILayout.ExpandWidth(false)))`
`440`	`442`	`{`
`441`		`- EditorUtility.DisplayDialog("Delete Branch?", "Are you sure you want to delete the branch: BRANCHNAME", "Delete", "Cancel");`
	`443`	`+ var selectedBranchName = selectedNode.Name;`
	`444`	`+ var dialogTitle = "Delete Branch: " + selectedBranchName;`
	`445`	`+ var dialogMessage = "Are you sure you want to delete the branch: " + selectedBranchName + "?";`
	`446`	`+ EditorUtility.DisplayDialog("Delete Branch?", dialogMessage, "Delete", "Cancel");`
`442`	`447`	`}`
	`448`	`+ GUI.enabled = true;`
`443`	`449`	`GUILayout.FlexibleSpace();`
`444`	`450`	`if (GUILayout.Button(CreateBranchButton, EditorStyles.miniButton, GUILayout.ExpandWidth(false)))`
`445`	`451`	`{`