Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit bf32283

Browse files
TaskBase null fix
When this class is dervied and used with no task set as it's dependency. It returns a false for success and should return a default value for T
1 parent 926e19d commit bf32283

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/GitHub.Api/Tasks/TaskBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ public TaskBase(CancellationToken token)
597597
{
598598
Task = new Task<TResult>(() =>
599599
{
600-
var ret = RunWithData(DependsOn?.Successful ?? previousSuccess, DependsOn.Successful ? ((ITask<T>)DependsOn).Result : default(T));
600+
var ret = RunWithData(DependsOn?.Successful ?? previousSuccess, (DependsOn?.Successful ?? false) ? ((ITask<T>)DependsOn).Result : default(T));
601601
tcs.SetResult(ret);
602602
AdjustNextTask(ret);
603603
return ret;

0 commit comments

Comments
 (0)