Utilizing the git user cache better

Author: StanleyGoldman

src/GitHub.Api/Git/GitClient.cs

@@ -123,7 +123,8 @@ private void GitUserCacheOnCacheUpdated(DateTimeOffset timeOffset)
 
         private void GitUserCacheOnCacheInvalidated()
         {
-
+            Logger.Trace("GitUserCache Invalidated");
+            UpdateUserAndEmail();
         }
 
         public void CheckUserChangedEvent(CacheUpdateEvent cacheUpdateEvent)
@@ -320,6 +321,8 @@ public ITask<string> SetConfig(string key, string value, GitConfigSource configS
 
         private void UpdateUserAndEmail()
         {
+            Logger.Trace("UpdateUserAndEmail");
+
             string username = null;
             string email = null;
 

src/GitHub.Api/Git/Repository.cs

@@ -665,13 +665,25 @@ public interface IUser
     [Serializable]
     public class User : IUser
     {
+        public string name;
+        public string email;
+
         public override string ToString()
         {
             return String.Format("Name: {0} Email: {1}", Name, Email);
         }
 
-        public string Name { get; set; }
-        public string Email { get; set; }
+        public string Name
+        {
+            get { return name; }
+            set { name = value; }
+        }
+
+        public string Email
+        {
+            get { return email; }
+            set { email = value; }
+        }
     }
 
     [Serializable]

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs

@@ -93,7 +93,7 @@ private void AttachHandlers()
         {
             if (GitClient != null)
             {
-                GitClient.CurrentUserChanged+=GitClientOnCurrentUserChanged;
+                GitClient.CurrentUserChanged += GitClientOnCurrentUserChanged;
             }
         }
 
@@ -124,9 +124,10 @@ private void MaybeUpdateData()
             if (userHasChanges)
             {
                 userHasChanges = false;
+                var currentUser = GitClient.CurrentUser;
+                isUserDataPresent = !string.IsNullOrEmpty(currentUser.Name)
+                    && !string.IsNullOrEmpty(currentUser.Email);
                 hasCompletedInitialCheck = true;
-                isUserDataPresent = !string.IsNullOrEmpty(GitClient.CurrentUser.Name)
-                    && !string.IsNullOrEmpty(GitClient.CurrentUser.Email);
             }
         }
 

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/UserSettingsView.cs

@@ -98,12 +98,14 @@ private void AttachHandlers()
 
         private void GitClientOnCurrentUserChanged(CacheUpdateEvent cacheUpdateEvent)
         {
+            Logger.Trace("GitClientOnCurrentUserChanged");
+
             if (!lastCheckUserChangedEvent.Equals(cacheUpdateEvent))
             {
-                new ActionTask(TaskManager.Token, () =>
-                    {
+                new ActionTask(TaskManager.Token, () => {
                         lastCheckUserChangedEvent = cacheUpdateEvent;
                         userHasChanges = true;
+                        isBusy = false;
                         Redraw();
                     })
                     { Affinity = TaskAffinity.UI }.Start();
@@ -123,8 +125,9 @@ private void MaybeUpdateData()
             if (userHasChanges)
             {
                 userHasChanges = false;
-                gitName = newGitName = GitClient.CurrentUser.Name;
-                gitEmail = newGitEmail = GitClient.CurrentUser.Email;
+                var currentUser = GitClient.CurrentUser;
+                gitName = newGitName = currentUser.Name;
+                gitEmail = newGitEmail = currentUser.Email;
             }
         }