Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit c08159c

Browse files
Return PopupWindow from Open method; Being sure to call InitializeWindow for PopupWindow
1 parent d9bede3 commit c08159c

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -395,8 +395,8 @@ public void OnEmbeddedGUI()
395395
var publishedClicked = GUILayout.Button(PublishButton, Styles.HistoryToolbarButtonStyle);
396396
if (publishedClicked)
397397
{
398-
var popupWindow = (PopupWindow)PopupWindow.Open(PopupWindow.PopupView.PublishView);
399-
popupWindow.Initialize(EntryPoint.ApplicationManager);
398+
var popupWindow = PopupWindow.Open(PopupWindow.PopupView.PublishView);
399+
popupWindow.InitializeWindow(EntryPoint.ApplicationManager);
400400
}
401401
GUI.enabled = true;
402402
}

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ public enum PopupView
2222
[MenuItem("GitHub/Authenticate")]
2323
public static void Launch()
2424
{
25-
var popupWindow = (PopupWindow)Open(PopupView.AuthenticationView);
26-
popupWindow.Initialize(EntryPoint.ApplicationManager);
25+
var popupWindow = Open(PopupView.AuthenticationView);
26+
popupWindow.InitializeWindow(EntryPoint.ApplicationManager);
2727
}
2828

29-
public static IView Open(PopupView popupView, Action<bool> onClose = null)
29+
public static PopupWindow Open(PopupView popupView, Action<bool> onClose = null)
3030
{
3131
var popupWindow = GetWindow<PopupWindow>(true);
3232
if (onClose != null)

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,8 @@ private void DoAccountDropdown()
326326

327327
private void SignIn(object obj)
328328
{
329-
var popupWindow = (PopupWindow) PopupWindow.Open(PopupWindow.PopupView.AuthenticationView);
330-
popupWindow.Initialize(EntryPoint.ApplicationManager);
329+
var popupWindow = PopupWindow.Open(PopupWindow.PopupView.AuthenticationView);
330+
popupWindow.InitializeWindow(EntryPoint.ApplicationManager);
331331
}
332332

333333
private void GoToProfile(object obj)

0 commit comments

Comments
 (0)