Fix SimpleJson bug where it fails to properly deserialize List<>

shana · shana · commit c25f6e94f0a4 · 2018-05-08T15:17:12.000+02:00
diff --git a/src/GitHub.Api/Helpers/SimpleJson.cs b/src/GitHub.Api/Helpers/SimpleJson.cs
@@ -1274,7 +1274,7 @@ protected virtual string MapClrMemberNameToJsonFieldName(string clrPropertyName)
 
         internal virtual ReflectionUtils.ConstructorDelegate ContructorDelegateFactory(Type key)
         {
-            return ReflectionUtils.GetContructor(key, key.IsArray ? ArrayConstructorParameterTypes : EmptyTypes);
+            return ReflectionUtils.GetContructor(key, (key.IsArray || ReflectionUtils.IsAssignableFrom(typeof(IList), key))? ArrayConstructorParameterTypes : EmptyTypes);
         }
 
         internal virtual IDictionary<string, ReflectionUtils.GetDelegate> GetterValueFactory(Type type)

Original file line number	Diff line number	Diff line change
`@@ -1274,7 +1274,7 @@ protected virtual string MapClrMemberNameToJsonFieldName(string clrPropertyName)`
`1274`	`1274`
`1275`	`1275`	`internal virtual ReflectionUtils.ConstructorDelegate ContructorDelegateFactory(Type key)`
`1276`	`1276`	`{`
`1277`		`- return ReflectionUtils.GetContructor(key, key.IsArray ? ArrayConstructorParameterTypes : EmptyTypes);`
	`1277`	`+ return ReflectionUtils.GetContructor(key, (key.IsArray \|\| ReflectionUtils.IsAssignableFrom(typeof(IList), key))? ArrayConstructorParameterTypes : EmptyTypes);`
`1278`	`1278`	`}`
`1279`	`1279`
`1280`	`1280`	`internal virtual IDictionary<string, ReflectionUtils.GetDelegate> GetterValueFactory(Type type)`