Changing RepositoryManager OnLocalBranchListUpdated and OnRemoteBranchListUpdated to use Dictionary instead of IDictionary

Author: StanleyGoldman

src/GitHub.Api/Cache/CacheInterfaces.cs

@@ -89,8 +89,8 @@ public interface IBranchCache : IManagedCache
         void AddLocalBranch(string branch);
         void AddRemoteBranch(string remote, string branch);
         void RemoveRemoteBranch(string remote, string branch);
-        void SetRemotes(IDictionary<string, ConfigRemote> remoteDictionary, IDictionary<string, IDictionary<string, ConfigBranch>> branchDictionary);
-        void SetLocals(IDictionary<string, ConfigBranch> branchDictionary);
+        void SetRemotes(Dictionary<string, ConfigRemote> remoteDictionary, Dictionary<string, Dictionary<string, ConfigBranch>> branchDictionary);
+        void SetLocals(Dictionary<string, ConfigBranch> branchDictionary);
     }
 
     public interface IRepositoryInfoCache : IManagedCache

src/GitHub.Api/Git/Repository.cs

@@ -418,8 +418,8 @@ private void RepositoryManager_OnLocalBranchUpdated(string name)
             }
         }
 
-        private void RepositoryManager_OnRemoteBranchListUpdated(IDictionary<string, ConfigRemote> remotes,
-            IDictionary<string, IDictionary<string, ConfigBranch>> branches)
+        private void RepositoryManager_OnRemoteBranchListUpdated(Dictionary<string, ConfigRemote> remotes,
+            Dictionary<string, Dictionary<string, ConfigBranch>> branches)
         {
             new ActionTask(CancellationToken.None, () => {
                 cacheContainer.BranchCache.SetRemotes(remotes, branches);
@@ -434,7 +434,7 @@ private void UpdateRemoteAndRemoteBranches()
             RemoteBranches = RemoteConfigBranches.Values.SelectMany(x => x.Values).Select(GetRemoteGitBranch).ToArray();
         }
 
-        private void RepositoryManager_OnLocalBranchListUpdated(IDictionary<string, ConfigBranch> branches)
+        private void RepositoryManager_OnLocalBranchListUpdated(Dictionary<string, ConfigBranch> branches)
         {
             new ActionTask(CancellationToken.None, () => {
                 cacheContainer.BranchCache.SetLocals(branches);

src/GitHub.Api/Git/RepositoryManager.cs

@@ -12,11 +12,11 @@ public interface IRepositoryManager : IDisposable
         event Action<IUser> OnGitUserLoaded;
         event Action<bool> OnIsBusyChanged;
         event Action<string> OnLocalBranchAdded;
-        event Action<IDictionary<string, ConfigBranch>> OnLocalBranchListUpdated;
+        event Action<Dictionary<string, ConfigBranch>> OnLocalBranchListUpdated;
         event Action<string> OnLocalBranchRemoved;
         event Action<string> OnLocalBranchUpdated;
         event Action<string, string> OnRemoteBranchAdded;
-        event Action<IDictionary<string, ConfigRemote>, IDictionary<string, IDictionary<string, ConfigBranch>>> OnRemoteBranchListUpdated;
+        event Action<Dictionary<string, ConfigRemote>, Dictionary<string, Dictionary<string, ConfigBranch>>> OnRemoteBranchListUpdated;
         event Action<string, string> OnRemoteBranchRemoved;
         event Action OnRepositoryUpdated;
 
@@ -106,11 +106,11 @@ class RepositoryManager : IRepositoryManager
         public event Action<IUser> OnGitUserLoaded;
         public event Action<bool> OnIsBusyChanged;
         public event Action<string> OnLocalBranchAdded;
-        public event Action<IDictionary<string, ConfigBranch>> OnLocalBranchListUpdated;
+        public event Action<Dictionary<string, ConfigBranch>> OnLocalBranchListUpdated;
         public event Action<string> OnLocalBranchRemoved;
         public event Action<string> OnLocalBranchUpdated;
         public event Action<string, string> OnRemoteBranchAdded;
-        public event Action<IDictionary<string, ConfigRemote>, IDictionary<string, IDictionary<string, ConfigBranch>>> OnRemoteBranchListUpdated;
+        public event Action<Dictionary<string, ConfigRemote>, Dictionary<string, Dictionary<string, ConfigBranch>>> OnRemoteBranchListUpdated;
         public event Action<string, string> OnRemoteBranchRemoved;
         public event Action OnRepositoryUpdated;
 
@@ -505,7 +505,7 @@ private void LoadRemotesFromConfig()
             Logger.Trace("LoadRemotesFromConfig");
 
             var remotes = config.GetRemotes().ToArray().ToDictionary(x => x.Name, x => x);
-            var remoteBranches = new Dictionary<string, IDictionary<string, ConfigBranch>>();
+            var remoteBranches = new Dictionary<string, Dictionary<string, ConfigBranch>>();
 
             foreach (var remote in remotes.Keys)
             {

src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs

@@ -222,7 +222,7 @@ class RemoteConfigBranchDictionary : Dictionary<string, Dictionary<string, Confi
         public RemoteConfigBranchDictionary()
         { }
 
-        public RemoteConfigBranchDictionary(IDictionary<string, IDictionary<string, ConfigBranch>> dictionary)
+        public RemoteConfigBranchDictionary(Dictionary<string, Dictionary<string, ConfigBranch>> dictionary)
         {
             foreach (var pair in dictionary)
             {
@@ -712,7 +712,7 @@ public void RemoveRemoteBranch(string remote, string branch)
             }
         }
 
-        public void SetRemotes(IDictionary<string, ConfigRemote> remoteDictionary, IDictionary<string, IDictionary<string, ConfigBranch>> branchDictionary)
+        public void SetRemotes(Dictionary<string, ConfigRemote> remoteDictionary, Dictionary<string, Dictionary<string, ConfigBranch>> branchDictionary)
         {
             var now = DateTimeOffset.Now;
             configRemotes = new ConfigRemoteDictionary(remoteDictionary);
@@ -721,7 +721,7 @@ public void SetRemotes(IDictionary<string, ConfigRemote> remoteDictionary, IDict
             SaveData(now, true);
         }
 
-        public void SetLocals(IDictionary<string, ConfigBranch> branchDictionary)
+        public void SetLocals(Dictionary<string, ConfigBranch> branchDictionary)
         {
             var now = DateTimeOffset.Now;
             localConfigBranches = new LocalConfigBranchDictionary(branchDictionary);