Setting up a download sequence to show it works

Author: StanleyGoldman

src/GitHub.Api/Tasks/DownloadTask.cs

@@ -130,7 +130,7 @@ protected override void Run(bool success)
 
                         if (!result)
                         {
-                            Logger.Warning($"Downloaded MD5 {md5} does not match expected. Deleting {Destination}.");
+                            Logger.Warning($"Downloaded MD5 {md5} does not match {ValidationHash}. Deleting {Destination}.");
                             fileSystem.FileDelete(Destination);
                         }
                         else
@@ -237,7 +237,7 @@ public bool Download()
 
         protected string Destination { get; }
 
-        protected string ValidationHash { get; }
+        public string ValidationHash { get; set; }
 
         protected int RetryCount { get; }
     }
@@ -264,23 +264,41 @@ public DownloadTextTask(CancellationToken token, string url)
 
         protected override string RunWithReturn(bool success)
         {
-            base.RunWithReturn(success);
+            var result = base.RunWithReturn(success);
 
             RaiseOnStart();
 
-            var webRequest = WebRequest.Create(Url);
-            webRequest.Method = "GET";
-            webRequest.Timeout = 3000;
-
-            using (var webResponse = (HttpWebResponse) webRequest.GetResponseWithoutException())
+            try
             {
-                var webResponseCharacterSet = webResponse.CharacterSet ?? Encoding.UTF8.BodyName;
-                var encoding = Encoding.GetEncoding(webResponseCharacterSet);
+                Logger.Trace($"Downloading {Url}");
+                var webRequest = WebRequest.Create(Url);
+                webRequest.Method = "GET";
+                webRequest.Timeout = 3000;
 
-                using (var responseStream = webResponse.GetResponseStream())
-                using (var reader = new StreamReader(responseStream, encoding))
-                    return reader.ReadToEnd();
+                using (var webResponse = (HttpWebResponse)webRequest.GetResponseWithoutException())
+                {
+                    var webResponseCharacterSet = webResponse.CharacterSet ?? Encoding.UTF8.BodyName;
+                    var encoding = Encoding.GetEncoding(webResponseCharacterSet);
+
+                    using (var responseStream = webResponse.GetResponseStream())
+                    using (var reader = new StreamReader(responseStream, encoding))
+                    {
+                        result = reader.ReadToEnd();
+                    }
+                }
+            }
+            catch (Exception ex)
+            {
+                Errors = ex.Message;
+                if (!RaiseFaultHandlers(new DownloadException("Error downloading text", ex)))
+                    throw;
             }
+            finally
+            {
+                RaiseOnEnd(result);
+            }
+
+            return result;
         }
 
         protected virtual void UpdateProgress(float progress)

src/tests/IntegrationTests/Download/DownloadTaskTests.cs

@@ -92,5 +92,57 @@ public void TestDownloadTextTask()
             var resultLines = result.Split(new[] { '\n' }, StringSplitOptions.RemoveEmptyEntries);
             resultLines[0].Should().Be("# If you would like to crawl GitHub contact us at [email protected].");
         }
+        
+        [Test]
+        public void TestDownloadFileAndHash()
+        {
+            InitializeTaskManager();
+
+            var gitArchivePath = TestBasePath.Combine("git.zip");
+            var gitLfsArchivePath = TestBasePath.Combine("git-lfs.zip");
+
+            var fileSystem = new FileSystem();
+
+            var downloadGitMd5Task = new DownloadTextTask(CancellationToken.None,
+                "https://ghfvs-installer.github.com/unity/portable_git/git.zip.MD5.txt?cb=1");
+
+            var downloadGitTask = new DownloadTask(CancellationToken.None, fileSystem,
+                "https://ghfvs-installer.github.com/unity/portable_git/git.zip", gitArchivePath, retryCount: 1);
+
+            var downloadGitLfsMd5Task = new DownloadTextTask(CancellationToken.None,
+                "https://ghfvs-installer.github.com/unity/portable_git/git-lfs.zip.MD5.txt?cb=1");
+
+            var downloadGitLfsTask = new DownloadTask(CancellationToken.None, fileSystem,
+                "https://ghfvs-installer.github.com/unity/portable_git/git-lfs.zip", gitLfsArchivePath, retryCount: 1);
+
+            var result = true;
+            Exception exception = null;
+
+            var autoResetEvent = new AutoResetEvent(false);
+
+            downloadGitMd5Task
+                .Then((b, s) =>
+                {
+                    downloadGitTask.ValidationHash = s;
+                })
+                .Then(downloadGitTask)
+                .Then(downloadGitLfsMd5Task)
+                .Then((b, s) =>
+                {
+                    downloadGitLfsTask.ValidationHash = s;
+                })
+                .Then(downloadGitLfsTask)
+                .Finally((b, ex) => {
+                    result = b;
+                    exception = ex;
+                    autoResetEvent.Set();
+                })
+                .Start();
+
+            autoResetEvent.WaitOne();
+
+            result.Should().BeTrue();
+            exception.Should().BeNull();
+        }
     }
 }