Tweaking the way dates are stored

Author: StanleyGoldman

src/GitHub.Api/Helpers/Constants.cs

@@ -13,13 +13,23 @@ static class Constants
         public const string GitTimeoutKey = "GitTimeout";
         public const string Iso8601Format = @"yyyy-MM-dd\THH\:mm\:ss.fffzzz";
         public const string Iso8601FormatZ = @"yyyy-MM-dd\THH\:mm\:ss\Z";
-        public const string Iso8601FormatPointZ = @"yyyy-MM-dd\THH\:mm\:ss.ff\Z";
         public static readonly string[] Iso8601Formats = {
+            Iso8601Format,
             Iso8601FormatZ,
             @"yyyy-MM-dd\THH\:mm\:ss.fffffffzzz",
-            Iso8601Format,
-            Iso8601FormatPointZ,
+            @"yyyy-MM-dd\THH\:mm\:ss.ffffffzzz",
+            @"yyyy-MM-dd\THH\:mm\:ss.fffffzzz",
+            @"yyyy-MM-dd\THH\:mm\:ss.ffffzzz",
+            @"yyyy-MM-dd\THH\:mm\:ss.ffzzz",
+            @"yyyy-MM-dd\THH\:mm\:ss.fzzz",
             @"yyyy-MM-dd\THH\:mm\:sszzz",
+            @"yyyy-MM-dd\THH\:mm\:ss.fffffff\Z",
+            @"yyyy-MM-dd\THH\:mm\:ss.ffffff\Z",
+            @"yyyy-MM-dd\THH\:mm\:ss.fffff\Z",
+            @"yyyy-MM-dd\THH\:mm\:ss.ffff\Z",
+            @"yyyy-MM-dd\THH\:mm\:ss.fff\Z",
+            @"yyyy-MM-dd\THH\:mm\:ss.ff\Z",
+            @"yyyy-MM-dd\THH\:mm\:ss.f\Z",
         };
         public const DateTimeStyles DateTimeStyle = DateTimeStyles.AssumeUniversal | DateTimeStyles.AdjustToUniversal;
         public const string SkipVersionKey = "SkipVersion";

src/GitHub.Api/Helpers/SimpleJson.cs

@@ -1250,17 +1250,7 @@ class PocoJsonSerializerStrategy : IJsonSerializerStrategy
         internal static readonly Type[] EmptyTypes = new Type[0];
         internal static readonly Type[] ArrayConstructorParameterTypes = new Type[] { typeof(int) };
 
-        private static readonly string[] Iso8601Format = new string[]
-                                                             {
-                                                                @"yyyy-MM-dd\THH\:mm\:sszzz",
-                                                                @"yyyy-MM-dd\THH\:mm\:ss.fffffffzzz",
-                                                                @"yyyy-MM-dd\THH\:mm\:ss.fffzzz",
-                                                                @"yyyy-MM-dd\THH\:mm\:ss\Z",
-                                                                @"yyyy-MM-dd\THH:mm:ss.fffffffzzz",
-                                                                @"yyyy-MM-dd\THH:mm:ss.fffzzz",
-                                                                @"yyyy-MM-dd\THH:mm:sszzz",
-                                                                @"yyyy-MM-dd\THH:mm:ss\Z",
-                                                             };
+        private static readonly string[] Iso8601Formats = Constants.Iso8601Formats;
 
         public PocoJsonSerializerStrategy()
         {
@@ -1504,9 +1494,9 @@ protected virtual bool TrySerializeKnownTypes(object input, out object output)
             if (input is NPath || input is UriString)
                 output = input.ToString();
             else if (input is DateTime)
-                output = ((DateTime)input).ToUniversalTime().ToString(Iso8601Format[0], CultureInfo.InvariantCulture);
+                output = ((DateTime)input).ToUniversalTime().ToString(Iso8601Formats[0], CultureInfo.InvariantCulture);
             else if (input is DateTimeOffset)
-                output = ((DateTimeOffset)input).ToUniversalTime().ToString(Iso8601Format[0], CultureInfo.InvariantCulture);
+                output = ((DateTimeOffset)input).ToUniversalTime().ToString(Iso8601Formats[0], CultureInfo.InvariantCulture);
             else if (input is Guid)
                 output = ((Guid)input).ToString("D");
             else if (input is Uri)

src/tests/UnitTests/IO/LockOutputProcessorTests.cs

@@ -74,7 +74,7 @@ public void ShouldParseTwoLocksFormat()
         [Test]
         public void ShouldParseVSTSLocksFormat()
         {
-            var nowString = DateTimeOffset.UtcNow.ToString(Constants.Iso8601FormatPointZ);
+            var nowString = DateTimeOffset.UtcNow.ToString(@"yyyy-MM-dd\THH\:mm\:ss.ff\Z");
             var now = DateTimeOffset.ParseExact(nowString, Constants.Iso8601Formats, CultureInfo.InvariantCulture, DateTimeStyles.AssumeUniversal);
             var output = new[]
             {