Stacking tasks in order to get the desired async forks

Author: StanleyGoldman

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -51,10 +51,63 @@ public void Run(bool firstRun)
             var afterGitSetup = new ActionTask(CancellationToken, RestartRepository)
                 .ThenInUI(InitializeUI);
 
-//            SetupGit()
-//                .Then(RestartRepository)
-//                .ThenInUI(InitializeUI)
-//                .Start();
+            Logger.Trace("afterGitSetup");
+
+            var windowsCredentialSetup = new ActionTask(CancellationToken, () => {
+                GitClient.GetConfig("credential.helper", GitConfigSource.Global).Then((b, credentialHelper) => {
+                    if (!string.IsNullOrEmpty(credentialHelper))
+                    {
+                        Logger.Trace("Windows CredentialHelper: {0}", credentialHelper);
+                        afterGitSetup.Start();
+                    }
+                    else
+                    {
+                        Logger.Warning("No Windows CredentialHeloper found: Setting to wincred");
+
+                        GitClient.SetConfig("credential.helper", "wincred", GitConfigSource.Global)
+                                 .Then(() => { afterGitSetup.Start(); }).Start();
+                    }
+                }).Start();
+            });
+
+            Logger.Trace("windowsCredentialSetup");
+
+            var afterPathDetermined = new ActionTask<NPath>(CancellationToken, (b1, path) => {
+
+                Logger.Trace("Setting Environment git path: {0}", path);
+                Environment.GitExecutablePath = path;
+
+            }).ThenInUI(() => {
+
+                Environment.User.Initialize(GitClient);
+
+                if (Environment.IsWindows)
+                {
+                    windowsCredentialSetup.Start();
+                }
+                else
+                {
+                    afterGitSetup.Start();
+                }
+            });
+
+            Logger.Trace("afterPathDetermined");
+
+            var applicationDataPath = Environment.GetSpecialFolder(System.Environment.SpecialFolder.LocalApplicationData).ToNPath();
+            var installDetails = new PortableGitInstallDetails(applicationDataPath, true);
+
+            var gitInstaller = new GitInstaller(Environment, CancellationToken, installDetails);
+            gitInstaller.SetupGitIfNeeded(new ActionTask<NPath>(CancellationToken, (b, s) => {
+
+                Logger.Trace("Success: {0}", s);
+
+                new FuncTask<NPath>(CancellationToken, () => s)
+                    .Then(afterPathDetermined)
+                    .Start();
+
+            }), new ActionTask(CancellationToken, () => {
+                Logger.Trace("Failure");
+            }) );
         }
 
         private ITask SetupGit()

src/GitHub.Api/GitHub.Api.csproj

@@ -117,6 +117,7 @@
     <Compile Include="Application\ApplicationManagerBase.cs" />
     <Compile Include="Helpers\Constants.cs" />
     <Compile Include="Helpers\Validation.cs" />
+    <Compile Include="Installer\GitInstaller.cs" />
     <Compile Include="Installer\PortableGitInstallTask.cs" />
     <Compile Include="Installer\ShortCircuitTask.cs" />
     <Compile Include="Installer\UnzipTask.cs" />

src/GitHub.Api/Installer/GitInstaller.cs

@@ -0,0 +1,87 @@
+using System;
+using System.Threading;
+
+namespace GitHub.Unity
+{
+    class GitInstaller
+    {
+        private static ILogging Logger = Logging.GetLogger<GitInstaller>();
+
+        private readonly IEnvironment environment;
+        private readonly IZipHelper sharpZipLibHelper;
+        private readonly CancellationToken cancellationToken;
+        private readonly PortableGitInstallDetails installDetails;
+
+        public GitInstaller(IEnvironment environment, CancellationToken cancellationToken, PortableGitInstallDetails installDetails)
+            : this(environment, null, cancellationToken, installDetails)
+        {
+        }
+
+        public GitInstaller(IEnvironment environment, IZipHelper sharpZipLibHelper, CancellationToken cancellationToken, PortableGitInstallDetails installDetails)
+        {
+            this.environment = environment;
+            this.sharpZipLibHelper = sharpZipLibHelper;
+            this.cancellationToken = cancellationToken;
+            this.installDetails = installDetails;
+        }
+
+        public void SetupGitIfNeeded(ActionTask<NPath> onSuccess, ITask onFailure)
+        {
+            Logger.Trace("SetupGitIfNeeded");
+
+            if (!environment.IsWindows)
+            {
+                onFailure.Start();
+            }
+
+            new FuncTask<bool>(cancellationToken, IsPortableGitExtracted)
+                .Then((success, isPortableGitExtracted) => {
+
+                    Logger.Trace("IsPortableGitExtracted: {0}", isPortableGitExtracted);
+
+                    if (isPortableGitExtracted)
+                    {
+                        new FuncTask<NPath>(cancellationToken, () => installDetails.GitExecPath)
+                            .Then(onSuccess)
+                            .Start();
+                    }
+                    else
+                    {
+                        new PortableGitInstallTask(cancellationToken, environment, installDetails).Then((b, path) => {
+                            if (b && path != null)
+                            {
+                                new FuncTask<NPath>(cancellationToken, () => path)
+                                    .Then(onSuccess)
+                                    .Start();
+                            }
+                            else
+                            {
+                                onFailure.Start();
+                            }
+                        }).Start();
+                        
+                    }
+
+                }).Start();
+        }
+
+        private bool IsPortableGitExtracted()
+        {
+            if (!installDetails.GitInstallPath.DirectoryExists())
+            {
+                Logger.Trace("{0} does not exist", installDetails.GitInstallPath);
+                return false;
+            }
+
+            var fileListMD5 = environment.FileSystem.CalculateFolderMD5(installDetails.GitInstallPath, false);
+            if (!fileListMD5.Equals(PortableGitInstallDetails.FileListMD5, StringComparison.InvariantCultureIgnoreCase))
+            {
+                Logger.Trace("MD5 {0} does not match expected {1}", fileListMD5, PortableGitInstallDetails.FileListMD5);
+                return false;
+            }
+
+            Logger.Trace("Git Present");
+            return true;
+        }
+    }
+}

src/GitHub.Api/Installer/PortableGitInstallTask.cs

@@ -69,12 +69,6 @@ protected override NPath RunWithReturn(bool success)
 
             Logger.Trace("Starting PortableGitInstallTask");
 
-            if (IsPortableGitExtracted())
-            {
-                Logger.Trace("Completed PortableGitInstallTask");
-                return installDetails.GitExecPath;
-            }
-
             Token.ThrowIfCancellationRequested();
 
             installDetails.GitInstallPath.DeleteIfExists();
@@ -145,25 +139,6 @@ private bool MoveExtractTarget(NPath extractTarget)
             return true;
         }
 
-        private bool IsPortableGitExtracted()
-        {
-            if (!installDetails.GitInstallPath.DirectoryExists())
-            {
-                Logger.Trace("{0} does not exist", installDetails.GitInstallPath);
-                return false;
-            }
-
-            var fileListMD5 = environment.FileSystem.CalculateFolderMD5(installDetails.GitInstallPath, false);
-            if (!fileListMD5.Equals(PortableGitInstallDetails.FileListMD5, StringComparison.InvariantCultureIgnoreCase))
-            {
-                Logger.Trace("MD5 {0} does not match expected {1}", fileListMD5, PortableGitInstallDetails.FileListMD5);
-                return false;
-            }
-
-            Logger.Trace("Git Present");
-            return true;
-        }
-
         private bool InstallGit(NPath targetPath)
         {
             Logger.Trace("InstallGit");