Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit db45ff1

Browse files
committed
Manager and UsageTracker are never null so we don't have to worry about it
1 parent a4b0664 commit db45ff1

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ class SettingsView : Subview
5555

5656
[SerializeField] private bool metricsEnabled;
5757
[NonSerialized] private bool metricsHasChanged;
58-
[NonSerialized] private IUsageTracker usageTracker;
5958

6059
public override void OnEnable()
6160
{
@@ -144,17 +143,11 @@ public override void OnGUI()
144143
GUILayout.EndScrollView();
145144
}
146145

147-
public override void InitializeView(IView parent)
148-
{
149-
base.InitializeView(parent);
150-
usageTracker = Manager != null && Manager.UsageTracker != null ? Manager.UsageTracker : null;
151-
}
152-
153146
private void MaybeUpdateData()
154147
{
155148
if (metricsHasChanged)
156149
{
157-
metricsEnabled = usageTracker != null && usageTracker.Enabled;
150+
metricsEnabled = Manager.UsageTracker.Enabled;
158151
metricsHasChanged = false;
159152
}
160153

@@ -496,7 +489,7 @@ private void OnPrivacyGui()
496489
{
497490
GUILayout.Label(PrivacyTitle, EditorStyles.boldLabel);
498491

499-
EditorGUI.BeginDisabledGroup(isBusy || usageTracker == null);
492+
EditorGUI.BeginDisabledGroup(isBusy);
500493
{
501494
EditorGUI.BeginChangeCheck();
502495
{
@@ -506,7 +499,6 @@ private void OnPrivacyGui()
506499
{
507500
Manager.UsageTracker.Enabled = metricsEnabled;
508501
}
509-
510502
}
511503
EditorGUI.EndDisabledGroup();
512504
}

0 commit comments

Comments
 (0)