Make abstract class constructors protected

shana · shana · commit de373f29c527 · 2018-01-31T16:46:14.000+01:00
diff --git a/src/GitHub.Api/Tasks/TaskBase.cs b/src/GitHub.Api/Tasks/TaskBase.cs
@@ -70,15 +70,15 @@ public abstract class TaskBase : ITask
         protected event Func<Exception, bool> faultHandler;
         private event Action finallyHandler;
 
-        public TaskBase(CancellationToken token)
+        protected TaskBase(CancellationToken token)
         {
             Guard.ArgumentNotNull(token, "token");
 
             Token = token;
             Task = new Task(() => Run(DependsOn?.Successful ?? previousSuccess), Token, TaskCreationOptions.None);
         }
 
-        public TaskBase(Task task)
+        protected TaskBase(Task task)
         {
             Task = new Task(t =>
             {
@@ -398,7 +398,7 @@ abstract class TaskBase<TResult> : TaskBase, ITask<TResult>
         public new event Action<ITask<TResult>> OnStart;
         public new event Action<ITask<TResult>, TResult> OnEnd;
 
-        public TaskBase(CancellationToken token)
+        protected TaskBase(CancellationToken token)
             : base(token)
         {
             Task = new Task<TResult>(() =>
@@ -410,7 +410,7 @@ public TaskBase(CancellationToken token)
             }, Token, TaskCreationOptions.None);
         }
 
-        public TaskBase(Task<TResult> task)
+        protected TaskBase(Task<TResult> task)
             : base()
         {
             Task = new Task<TResult>(t =>

Original file line number	Diff line number	Diff line change
`@@ -70,15 +70,15 @@ public abstract class TaskBase : ITask`
`70`	`70`	`protected event Func<Exception, bool> faultHandler;`
`71`	`71`	`private event Action finallyHandler;`
`72`	`72`
`73`		`- public TaskBase(CancellationToken token)`
	`73`	`+ protected TaskBase(CancellationToken token)`
`74`	`74`	`{`
`75`	`75`	`Guard.ArgumentNotNull(token, "token");`
`76`	`76`
`77`	`77`	`Token = token;`
`78`	`78`	`Task = new Task(() => Run(DependsOn?.Successful ?? previousSuccess), Token, TaskCreationOptions.None);`
`79`	`79`	`}`
`80`	`80`
`81`		`- public TaskBase(Task task)`
	`81`	`+ protected TaskBase(Task task)`
`82`	`82`	`{`
`83`	`83`	`Task = new Task(t =>`
`84`	`84`	`{`
`@@ -398,7 +398,7 @@ abstract class TaskBase<TResult> : TaskBase, ITask<TResult>`
`398`	`398`	`public new event Action<ITask<TResult>> OnStart;`
`399`	`399`	`public new event Action<ITask<TResult>, TResult> OnEnd;`
`400`	`400`
`401`		`- public TaskBase(CancellationToken token)`
	`401`	`+ protected TaskBase(CancellationToken token)`
`402`	`402`	`: base(token)`
`403`	`403`	`{`
`404`	`404`	`Task = new Task<TResult>(() =>`
`@@ -410,7 +410,7 @@ public TaskBase(CancellationToken token)`
`410`	`410`	`}, Token, TaskCreationOptions.None);`
`411`	`411`	`}`
`412`	`412`
`413`		`- public TaskBase(Task<TResult> task)`
	`413`	`+ protected TaskBase(Task<TResult> task)`
`414`	`414`	`: base()`
`415`	`415`	`{`
`416`	`416`	`Task = new Task<TResult>(t =>`