Some more code analysis fixes

Author: shana

common/codeanalysis-debug.ruleset

@@ -106,6 +106,11 @@
 
     <!-- we're returning arrays from properties -->
     <Rule Id="CA1819" Action="None" />
+
+    <!-- Unity does its own serialization and doesn't need special serializable type constructors -->
+    <Rule Id="CA2229" Action="None" />
+    <Rule Id="CA2240" Action="None" />
+
   </Rules>
   <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.Features" RuleNamespace="Microsoft.CodeAnalysis.CSharp.Features">
     <Rule Id="IDE0001" Action="None" />

common/codeanalysis-release.ruleset

@@ -95,6 +95,10 @@
 
     <!-- we're returning arrays from properties -->
     <Rule Id="CA1819" Action="None" />
+
+    <!-- Unity does its own serialization and doesn't need special serializable type constructors -->
+    <Rule Id="CA2229" Action="None" />
+    <Rule Id="CA2240" Action="None" />
   </Rules>
   <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.Features" RuleNamespace="Microsoft.CodeAnalysis.CSharp.Features">
     <Rule Id="IDE0001" Action="None" />

src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs

@@ -2,12 +2,26 @@
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
+using System.Runtime.Serialization;
 using UnityEditor;
 using UnityEngine;
 using Application = UnityEngine.Application;
 
 namespace GitHub.Unity
 {
+    [Serializable]
+    public class SerializationException : Exception
+    {
+        public SerializationException() : base()
+        { }
+        public SerializationException(string message) : base(message)
+        { }
+        public SerializationException(string message, Exception innerException) : base(message, innerException)
+        { }
+        protected SerializationException(SerializationInfo info, StreamingContext context) : base(info, context)
+        { }
+    }
+
     sealed class ApplicationCache : ScriptObjectSingleton<ApplicationCache>
     {
         [SerializeField] private bool firstRun = true;
@@ -373,7 +387,7 @@ public void OnAfterDeserialize()
 
             if (keys.Length != subKeys.Length || subKeys.Length != subKeyValues.Length)
             {
-                throw new Exception("Deserialization length mismatch");
+                throw new SerializationException("Deserialization length mismatch");
             }
 
             for (var remoteIndex = 0; remoteIndex < keys.Length; remoteIndex++)
@@ -385,7 +399,7 @@ public void OnAfterDeserialize()
 
                 if (subKeyContainer.Values.Length != subKeyValueContainer.Values.Length)
                 {
-                    throw new Exception("Deserialization length mismatch");
+                    throw new SerializationException("Deserialization length mismatch");
                 }
 
                 var branchesDictionary = new Dictionary<string, ConfigBranch>();

src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationManager.cs

@@ -86,12 +86,12 @@ protected override void Dispose(bool disposing)
         {
             if (disposing)
             {
-                base.Dispose(disposing);
                 if (!disposed)
                 {
                     disposed = true;
                 }
             }
+            base.Dispose(disposing);
         }
 
         public override IProcessEnvironment GitEnvironment { get { return Platform.GitEnvironment; } }

src/UnityExtension/Assets/Editor/GitHub.Unity/ScriptObjectSingleton.cs

@@ -6,7 +6,7 @@
 namespace GitHub.Unity
 {
     [AttributeUsage(AttributeTargets.Class)]
-    class LocationAttribute : Attribute
+    sealed class LocationAttribute : Attribute
     {
         public enum Location { PreferencesFolder, ProjectFolder, LibraryFolder, UserFolder }
         public string filepath { get; set; }
@@ -102,11 +102,11 @@ protected virtual void Save(bool saveAsText)
                 return;
             }
 
-            NPath filePath = GetFilePath();
-            if (filePath != null)
+            NPath locationFilePath = GetFilePath();
+            if (locationFilePath != null)
             {
-                filePath.Parent.EnsureDirectoryExists();
-                InternalEditorUtility.SaveToSerializedFileAndForget(new[] { instance }, filePath, saveAsText);
+                locationFilePath.Parent.EnsureDirectoryExists();
+                InternalEditorUtility.SaveToSerializedFileAndForget(new[] { instance }, locationFilePath, saveAsText);
             }
         }
 

src/UnityExtension/Assets/Editor/GitHub.Unity/SerializableDictionary.cs

@@ -31,7 +31,7 @@ public void OnAfterDeserialize()
 
             if (keys.Count != values.Count)
             {
-                throw new Exception(
+                throw new SerializationException(
                     string.Format("there are {0} keys and {1} values after deserialization. Make sure that both key and value types are serializable.",
                         keys.Count, values.Count));
             }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

@@ -453,7 +453,7 @@ private Subview ToView(SubTab tab)
                 case SubTab.Settings:
                     return settingsView;
                 default:
-                    throw new ArgumentOutOfRangeException();
+                    throw new ArgumentOutOfRangeException("tab");
             }
         }