Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit e41f883

Browse files
StanleyGoldmanStanleyGoldman
authored
Merge pull request #493 from github-for-unity/fixes/use-more-defaults-properly
Providing a correct Default for GitConfig and GitRemote
2 parents c4e2e68 + e6032a5 commit e41f883

File tree

3 files changed

+52
-39
lines changed

3 files changed

+52
-39
lines changed

‎src/GitHub.Api/Git/GitConfig.cs

Lines changed: 42 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,56 @@ namespace GitHub.Unity
99
[Serializable]
1010
public struct ConfigRemote
1111
{
12-
public string Name;
13-
public string Url;
12+
public static ConfigRemote Default = new ConfigRemote(String.Empty, String.Empty);
13+
14+
public string name;
15+
public string url;
16+
17+
public ConfigRemote(string name, string url)
18+
{
19+
this.name = name;
20+
this.url = url;
21+
}
22+
23+
public string Name => name;
24+
25+
public string Url => url;
1426

1527
public override string ToString()
1628
{
17-
return String.Format("{{Remote {0} {1}}}", Name, Url);
29+
return $"{{Remote {Name} {Url}}}";
1830
}
1931
}
2032

2133
[Serializable]
2234
public struct ConfigBranch
2335
{
24-
public string Name;
25-
public ConfigRemote? Remote;
26-
public bool IsTracking => Remote.HasValue;
36+
public static ConfigBranch Default = new ConfigBranch(String.Empty);
37+
38+
public string name;
39+
public ConfigRemote remote;
40+
41+
public ConfigBranch(string name)
42+
{
43+
this.name = name;
44+
remote = ConfigRemote.Default;
45+
}
46+
47+
public ConfigBranch(string name, ConfigRemote? remote)
48+
{
49+
this.name = name;
50+
this.remote = remote ?? ConfigRemote.Default;
51+
}
52+
53+
public bool IsTracking => !remote.Equals(ConfigRemote.Default);
54+
55+
public string Name => name;
56+
57+
public ConfigRemote? Remote => remote;
2758

2859
public override string ToString()
2960
{
30-
return String.Format("{{Branch {0} {1}}}", Name, Remote?.ToString() ?? "Untracked");
61+
return $"{{Branch {Name} {Remote?.ToString() ?? "Untracked"}}}";
3162
}
3263
}
3364

@@ -74,11 +105,7 @@ public IEnumerable<ConfigBranch> GetBranches()
74105
return groups
75106
.Where(x => x.Key == "branch")
76107
.SelectMany(x => x.Value)
77-
.Select(x => new ConfigBranch
78-
{
79-
Name = x.Key,
80-
Remote = GetRemote(x.Value.TryGetString("remote"))
81-
});
108+
.Select(x => new ConfigBranch(x.Key, GetRemote(x.Value.TryGetString("remote"))));
82109
}
83110

84111
public IEnumerable<ConfigRemote> GetRemotes()
@@ -87,11 +114,7 @@ public IEnumerable<ConfigRemote> GetRemotes()
87114
.Where(x => x.Key == "remote")
88115
.SelectMany(x => x.Value)
89116
.Where(x => x.Value.TryGetString("url") != null)
90-
.Select(x => new ConfigRemote
91-
{
92-
Name = x.Key,
93-
Url = x.Value.TryGetString("url")
94-
});
117+
.Select(x => new ConfigRemote(x.Key, x.Value.TryGetString("url")));
95118
}
96119

97120
public ConfigRemote? GetRemote(string remote)
@@ -100,11 +123,7 @@ public IEnumerable<ConfigRemote> GetRemotes()
100123
.Where(x => x.Key == "remote")
101124
.SelectMany(x => x.Value)
102125
.Where(x => x.Key == remote && x.Value.TryGetString("url") != null)
103-
.Select(x => new ConfigRemote
104-
{
105-
Name = x.Key,
106-
Url = x.Value.GetString("url")
107-
} as ConfigRemote?)
126+
.Select(x => new ConfigRemote(x.Key,x.Value.GetString("url")) as ConfigRemote?)
108127
.FirstOrDefault();
109128
}
110129

@@ -114,11 +133,7 @@ public IEnumerable<ConfigRemote> GetRemotes()
114133
.Where(x => x.Key == "branch")
115134
.SelectMany(x => x.Value)
116135
.Where(x => x.Key == branch)
117-
.Select(x => new ConfigBranch
118-
{
119-
Name = x.Key,
120-
Remote = GetRemote(x.Value.TryGetString("remote"))
121-
} as ConfigBranch?)
136+
.Select(x => new ConfigBranch(x.Key,GetRemote(x.Value.TryGetString("remote"))) as ConfigBranch?)
122137
.FirstOrDefault();
123138
}
124139

‎src/GitHub.Api/Git/RepositoryManager.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using System.Linq;
44
using System.Threading;
55
using System.Threading.Tasks;
6+
using Octokit;
67

78
namespace GitHub.Unity
89
{
@@ -409,7 +410,7 @@ private void GetCurrentBranchAndRemote(out ConfigBranch? branch, out ConfigRemot
409410

410411
if (!branch.HasValue)
411412
{
412-
branch = new ConfigBranch { Name = branchName };
413+
branch = new ConfigBranch(branchName);
413414
}
414415
}
415416

@@ -512,7 +513,7 @@ private void UpdateLocalBranches(Dictionary<string, ConfigBranch> branches, NPat
512513
configBranches.Where(x => x.Name == branchName).Select(x => x as ConfigBranch?).FirstOrDefault();
513514
if (!branch.HasValue)
514515
{
515-
branch = new ConfigBranch { Name = branchName };
516+
branch = new ConfigBranch(branchName);
516517
}
517518
branches.Add(branchName, branch.Value);
518519
}
@@ -541,7 +542,7 @@ private void UpdateRemoteBranches()
541542
.Select(x => x.RelativeTo(basedir))
542543
.Select(x => x.ToString(SlashMode.Forward)))
543544
{
544-
branchList.Add(branch, new ConfigBranch { Name = branch, Remote = remotes[remote] });
545+
branchList.Add(branch, new ConfigBranch(branch, remotes[remote]));
545546
}
546547

547548
remoteBranches.Add(remote, branchList);

‎src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -498,9 +498,6 @@ public override TimeSpan DataTimeout
498498
[Location("cache/branches.yaml", LocationAttribute.Location.LibraryFolder)]
499499
sealed class BranchCache : ManagedCacheBase<BranchCache>, IBranchCache
500500
{
501-
public static readonly ConfigBranch DefaultConfigBranch = new ConfigBranch();
502-
public static readonly ConfigRemote DefaultConfigRemote = new ConfigRemote();
503-
504501
[SerializeField] private string lastUpdatedAtString = DateTimeOffset.MinValue.ToString();
505502
[SerializeField] private string lastVerifiedAtString = DateTimeOffset.MinValue.ToString();
506503
[SerializeField] private string initializedAtString = DateTimeOffset.MinValue.ToString();
@@ -524,7 +521,7 @@ public ConfigRemote? CurrentConfigRemote
524521
get
525522
{
526523
ValidateData();
527-
return gitConfigRemote.Equals(DefaultConfigRemote) ? (ConfigRemote?)null : gitConfigRemote;
524+
return gitConfigRemote.Equals(ConfigRemote.Default) ? (ConfigRemote?)null : gitConfigRemote;
528525
}
529526
set
530527
{
@@ -535,7 +532,7 @@ public ConfigRemote? CurrentConfigRemote
535532

536533
if (!Nullable.Equals(gitConfigRemote, value))
537534
{
538-
gitConfigRemote = value ?? DefaultConfigRemote;
535+
gitConfigRemote = value ?? ConfigRemote.Default;
539536
isUpdated = true;
540537
}
541538

@@ -548,7 +545,7 @@ public ConfigBranch? CurentConfigBranch
548545
get
549546
{
550547
ValidateData();
551-
return gitConfigBranch.Equals(DefaultConfigBranch) ? (ConfigBranch?)null : gitConfigBranch;
548+
return gitConfigBranch.Equals(ConfigBranch.Default) ? (ConfigBranch?)null : gitConfigBranch;
552549
}
553550
set
554551
{
@@ -559,7 +556,7 @@ public ConfigBranch? CurentConfigBranch
559556

560557
if (!Nullable.Equals(gitConfigBranch, value))
561558
{
562-
gitConfigBranch = value ?? DefaultConfigBranch;
559+
gitConfigBranch = value ?? ConfigBranch.Default;
563560
isUpdated = true;
564561
}
565562

@@ -674,7 +671,7 @@ public void AddLocalBranch(string branch)
674671
if (!LocalConfigBranches.ContainsKey(branch))
675672
{
676673
var now = DateTimeOffset.Now;
677-
LocalConfigBranches.Add(branch, new ConfigBranch { Name = branch });
674+
LocalConfigBranches.Add(branch, new ConfigBranch(branch));
678675
Logger.Trace("AddLocalBranch {0} branch:{1} ", now, branch);
679676
SaveData(now, true);
680677
}
@@ -692,7 +689,7 @@ public void AddRemoteBranch(string remote, string branch)
692689
if (!branchList.ContainsKey(branch))
693690
{
694691
var now = DateTimeOffset.Now;
695-
branchList.Add(branch, new ConfigBranch { Name = branch, Remote = ConfigRemotes[remote] });
692+
branchList.Add(branch, new ConfigBranch(branch,ConfigRemotes[remote]));
696693
Logger.Trace("AddRemoteBranch {0} remote:{1} branch:{2} ", now, remote, branch);
697694
SaveData(now, true);
698695
}

0 commit comments

Comments
 (0)