Simplifying some logic

StanleyGoldman · StanleyGoldman · commit e770b8873650 · 2017-08-08T11:30:42.000-04:00
diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/SettingsView.cs
@@ -644,13 +644,13 @@ private void OnInstallPathGUI()
 
         private void OnPrivacyGui()
         {
-            var service = Manager != null && Manager.UsageTracker != null ? Manager.UsageTracker : null;
+            var service = Manager != null ? Manager.UsageTracker : null;
 
             GUILayout.Label(PrivacyTitle, EditorStyles.boldLabel);
 
             GUI.enabled = !busy && service != null;
 
-            var metricsEnabled = service != null ? service.Enabled : false;
+            var metricsEnabled = service != null && service.Enabled;
             EditorGUI.BeginChangeCheck();
             {
                 metricsEnabled = GUILayout.Toggle(metricsEnabled, MetricsOptInLabel);

Original file line number	Diff line number	Diff line change
`@@ -644,13 +644,13 @@ private void OnInstallPathGUI()`
`644`	`644`
`645`	`645`	`private void OnPrivacyGui()`
`646`	`646`	`{`
`647`		`- var service = Manager != null && Manager.UsageTracker != null ? Manager.UsageTracker : null;`
	`647`	`+ var service = Manager != null ? Manager.UsageTracker : null;`
`648`	`648`
`649`	`649`	`GUILayout.Label(PrivacyTitle, EditorStyles.boldLabel);`
`650`	`650`
`651`	`651`	`GUI.enabled = !busy && service != null;`
`652`	`652`
`653`		`- var metricsEnabled = service != null ? service.Enabled : false;`
	`653`	`+ var metricsEnabled = service != null && service.Enabled;`
`654`	`654`	`EditorGUI.BeginChangeCheck();`
`655`	`655`	`{`
`656`	`656`	`metricsEnabled = GUILayout.Toggle(metricsEnabled, MetricsOptInLabel);`