Functionality to set parent node from meta

Author: StanleyGoldman

src/GitHub.Api/UI/TreeBase.cs

@@ -183,23 +183,9 @@ protected bool PromoteNode(TNode previouslyAddedNode, string nextLabel)
 
         public void SetCheckStateOnAll(bool isChecked)
         {
-            var nodeCheckState = isChecked ? CheckState.Checked : CheckState.Empty;
             foreach (var node in Nodes)
             {
-                var wasChecked = node.CheckState == CheckState.Checked;
-                node.CheckState = nodeCheckState;
-
-                if (!node.IsFolder)
-                {
-                    if (isChecked && !wasChecked)
-                    {
-                        AddCheckedNode(node);
-                    }
-                    else if (!isChecked && wasChecked)
-                    {
-                        RemoveCheckedNode(node);
-                    }
-                }
+                SetCheckStateOnNode(node, isChecked ? CheckState.Checked : CheckState.Empty);
             }
         }
 
@@ -250,60 +236,42 @@ protected void ToggleNodeVisibility(int idx, TNode node)
 
         protected void ToggleNodeChecked(int idx, TNode node)
         {
+            CheckState checkState;
             var isChecked = false;
-
             switch (node.CheckState)
             {
                 case CheckState.Mixed:
                 case CheckState.Empty:
-                    node.CheckState = CheckState.Checked;
+                    checkState = CheckState.Checked;
                     isChecked = true;
                     break;
 
                 case CheckState.Checked:
-                    node.CheckState = CheckState.Empty;
+                    checkState = CheckState.Empty;
                     break;
-            }
 
-            if (!node.IsFolder)
-            {
-                if (isChecked)
-                {
-                    AddCheckedNode(node);
-                }
-                else
-                {
-                    RemoveCheckedNode(node);
-                }
+                default:
+                    throw new ArgumentOutOfRangeException("Unknown CheckState");
             }
 
+            SetCheckStateOnNode(node, checkState);
+
             if (node.IsFolderOrContainer)
             {
                 ToggleChildrenChecked(idx, node, isChecked);
             }
 
-            ToggleParentFoldersChecked(idx, node, isChecked);
+            ToggleParentFolderAndContainersChecked(idx, node, isChecked);
         }
 
         private void ToggleChildrenChecked(int idx, TNode node, bool isChecked)
         {
             for (var i = idx + 1; i < Nodes.Count && node.Level < Nodes[i].Level; i++)
             {
                 var childNode = Nodes[i];
-                var wasChecked = childNode.CheckState == CheckState.Checked;
-                childNode.CheckState = isChecked ? CheckState.Checked : CheckState.Empty;
 
-                if (!childNode.IsFolder)
-                {
-                    if (isChecked && !wasChecked)
-                    {
-                        AddCheckedNode(childNode);
-                    }
-                    else if (!isChecked && wasChecked)
-                    {
-                        RemoveCheckedNode(childNode);
-                    }
-                }
+                var wasChecked = childNode.CheckState == CheckState.Checked;
+                SetCheckStateOnNode(node, isChecked ? CheckState.Checked : CheckState.Empty);
 
                 if (childNode.IsFolderOrContainer)
                 {
@@ -332,7 +300,29 @@ private List<TNode> GetLeafNodes(TNode node, int idx)
             return results;
         }
 
-        private void ToggleParentFoldersChecked(int idx, TNode node, bool isChecked)
+        private void SetCheckStateOnNode(TNode node, CheckState nodeCheckState)
+        {
+            var isChecked = nodeCheckState == CheckState.Checked
+                || nodeCheckState == CheckState.Mixed;
+
+            var wasChecked = node.CheckState == CheckState.Checked;
+
+            node.CheckState = nodeCheckState;
+
+            if (!node.IsFolder)
+            {
+                if (isChecked && !wasChecked)
+                {
+                    AddCheckedNode(node);
+                }
+                else if (!isChecked && wasChecked)
+                {
+                    RemoveCheckedNode(node);
+                }
+            }
+        }
+
+        private void ToggleParentFolderAndContainersChecked(int idx, TNode node, bool isChecked)
         {
             while (true)
             {
@@ -383,14 +373,15 @@ private void ToggleParentFoldersChecked(int idx, TNode node, bool isChecked)
 
                     var parentIndex = firstSiblingIndex - 1;
                     var parentNode = Nodes[parentIndex];
-                    if (siblingsInSameState)
-                    {
-                        parentNode.CheckState = isChecked ? CheckState.Checked : CheckState.Empty;
-                    }
-                    else
-                    {
-                        parentNode.CheckState = CheckState.Mixed;
-                    }
+
+                    var parentNodeState =
+                        siblingsInSameState
+                            ? isChecked
+                                ? CheckState.Checked
+                                : CheckState.Empty
+                            : CheckState.Mixed;
+
+                    SetCheckStateOnNode(parentNode, parentNodeState);
 
                     idx = parentIndex;
                     node = parentNode;

src/tests/UnitTests/UI/TreeBaseTests.cs

@@ -671,6 +671,9 @@ public void ShouldCheckParentOfMetaFile()
             var sceneNode = testTree.CreatedTreeNodes[2];
             var sceneMetaNode = testTree.CreatedTreeNodes[3];
 
+            Assert.AreEqual(CheckState.Empty, sceneNode.CheckState);
+            Assert.AreEqual(CheckState.Empty, sceneMetaNode.CheckState);
+
             testTree.ToggleNodeChecked(3, sceneMetaNode);
 
             Assert.AreEqual(CheckState.Checked, sceneNode.CheckState);