Preventing the usage of InitProjectView and SettingsView if GitClient is not ready

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/GitPathView.cs

@@ -30,6 +30,13 @@ class GitPathView : Subview
 
         [NonSerialized] private bool isBusy;
         [NonSerialized] private bool gitExecHasChanged;
+        [NonSerialized] private bool gitExecutableIsSet;
+
+        public override void InitializeView(IView parent)
+        {
+            base.InitializeView(parent);
+            gitExecutableIsSet = Environment.GitExecutablePath != null;
+        }
 
         public override void OnEnable()
         {
@@ -48,7 +55,7 @@ public override void OnGUI()
             // Install path
             GUILayout.Label(GitInstallTitle, EditorStyles.boldLabel);
 
-            EditorGUI.BeginDisabledGroup(IsBusy || Parent.IsBusy);
+            EditorGUI.BeginDisabledGroup(!gitExecutableIsSet || IsBusy || Parent.IsBusy);
             {
                 // Install path field
                 GUILayout.BeginHorizontal();

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs

@@ -17,6 +17,13 @@ class InitProjectView : Subview
 
         [NonSerialized] private bool isBusy;
         [NonSerialized] private bool userHasChanges;
+        [NonSerialized] private bool gitExecutableIsSet;
+
+        public override void InitializeView(IView parent)
+        {
+            base.InitializeView(parent);
+            gitExecutableIsSet = Environment.GitExecutablePath != null;
+        }
 
         public override void OnEnable()
         {
@@ -54,7 +61,7 @@ public override void OnGUI()
                 {
                     GUILayout.FlexibleSpace();
 
-                    EditorGUI.BeginDisabledGroup(IsBusy || !isUserDataPresent);
+                    EditorGUI.BeginDisabledGroup(!gitExecutableIsSet || IsBusy || !isUserDataPresent);
                     {
                         if (GUILayout.Button(Localization.InitializeRepositoryButtonText, "Button"))
                         {
@@ -70,7 +77,7 @@ public override void OnGUI()
                 }
                 GUILayout.EndHorizontal();
 
-                if (hasCompletedInitialCheck && !isUserDataPresent)
+                if (gitExecutableIsSet && hasCompletedInitialCheck && !isUserDataPresent)
                 {
                     EditorGUILayout.Space();
                     EditorGUILayout.HelpBox(NoUserOrEmailError, MessageType.Error);

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/UserSettingsView.cs

@@ -7,9 +7,6 @@ namespace GitHub.Unity
     [Serializable]
     class UserSettingsView : Subview
     {
-        private static readonly Vector2 viewSize = new Vector2(325, 125);
-        private const string WindowTitle = "User Settings";
-
         private const string GitConfigTitle = "Git Configuration";
         private const string GitConfigNameLabel = "Name";
         private const string GitConfigEmailLabel = "Email";
@@ -24,12 +21,12 @@ class UserSettingsView : Subview
 
         [NonSerialized] private bool isBusy;
         [NonSerialized] private bool userHasChanges;
+        [NonSerialized] private bool gitExecutableIsSet;
 
         public override void InitializeView(IView parent)
         {
             base.InitializeView(parent);
-            Title = WindowTitle;
-            Size = viewSize;
+            gitExecutableIsSet = Environment.GitExecutablePath != null;
         }
 
         public override void OnDataUpdate()
@@ -42,7 +39,7 @@ public override void OnGUI()
         {
             GUILayout.Label(GitConfigTitle, EditorStyles.boldLabel);
 
-            EditorGUI.BeginDisabledGroup(IsBusy || Parent.IsBusy);
+            EditorGUI.BeginDisabledGroup(!gitExecutableIsSet || IsBusy || Parent.IsBusy);
             {
                 EditorGUI.BeginChangeCheck();
                 {