Moving private methods after public methods

Author: StanleyGoldman

src/GitHub.Api/Git/Repository.cs

@@ -42,97 +42,6 @@ public Repository(NPath localPath, ICacheContainer container)
             cacheContainer.CacheUpdated += CacheContainer_OnCacheUpdated;
         }
 
-        private void CacheContainer_OnCacheInvalidated(CacheType cacheType)
-        {
-            switch (cacheType)
-            {
-                case CacheType.BranchCache:
-                    break;
-
-                case CacheType.GitLogCache:
-                    break;
-
-                case CacheType.GitStatusCache:
-                    break;
-
-                case CacheType.GitLocksCache:
-                    break;
-
-                case CacheType.GitUserCache:
-                    break;
-
-                default:
-                    throw new ArgumentOutOfRangeException(nameof(cacheType), cacheType, null);
-            }
-        }
-
-        private void CacheContainer_OnCacheUpdated(CacheType cacheType, DateTimeOffset offset)
-        {
-            var cacheUpdateEvent = new CacheUpdateEvent { UpdatedTimeString = offset.ToString() };
-            switch (cacheType)
-            {
-                case CacheType.BranchCache:
-                    HandleBranchCacheUpdatedEvent(cacheUpdateEvent);
-                    break;
-
-                case CacheType.GitLogCache:
-                    HandleGitLogCacheUpdatedEvent(cacheUpdateEvent);
-                    break;
-
-                case CacheType.GitStatusCache:
-                    HandleGitStatusCacheUpdatedEvent(cacheUpdateEvent);
-                    break;
-
-                case CacheType.GitLocksCache:
-                    HandleGitLocksCacheUpdatedEvent(cacheUpdateEvent);
-                    break;
-
-                case CacheType.GitUserCache:
-                    break;
-
-                case CacheType.RepositoryInfoCache:
-                    HandleRepositoryInfoCacheUpdatedEvent(cacheUpdateEvent);
-                    break;
-
-                default:
-                    throw new ArgumentOutOfRangeException(nameof(cacheType), cacheType, null);
-            }
-        }
-
-        private void HandleRepositoryInfoCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
-        {
-            Logger.Trace("RepositoryInfoCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
-            CurrentBranchChanged?.Invoke(cacheUpdateEvent);
-            CurrentRemoteChanged?.Invoke(cacheUpdateEvent);
-            CurrentBranchAndRemoteChanged?.Invoke(cacheUpdateEvent);
-        }
-
-        private void HandleGitLocksCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
-        {
-            Logger.Trace("GitLocksCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
-            LocksChanged?.Invoke(cacheUpdateEvent);
-        }
-
-        private void HandleGitStatusCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
-        {
-            Logger.Trace("GitStatusCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
-            StatusChanged?.Invoke(cacheUpdateEvent);
-        }
-
-        private void HandleGitLogCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
-        {
-            Logger.Trace("GitLogCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
-            LogChanged?.Invoke(cacheUpdateEvent);
-        }
-
-        private void HandleBranchCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
-        {
-            Logger.Trace("BranchCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
-            LocalBranchListChanged?.Invoke(cacheUpdateEvent);
-            RemoteBranchListChanged?.Invoke(cacheUpdateEvent);
-            LocalAndRemoteBranchListChanged?.Invoke(cacheUpdateEvent);
-        }
-
         public void Initialize(IRepositoryManager initRepositoryManager)
         {
             Logger.Trace("Initialize");
@@ -309,6 +218,38 @@ public void CheckLocalAndRemoteBranchListChangedEvent(CacheUpdateEvent cacheUpda
             CheckBranchCacheEvent(cacheUpdateEvent);
         }
 
+        /// <summary>
+        /// Note: We don't consider CloneUrl a part of the hash code because it can change during the lifetime
+        /// of a repository. Equals takes care of any hash collisions because of this
+        /// </summary>
+        /// <returns></returns>
+        public override int GetHashCode()
+        {
+            return LocalPath.GetHashCode();
+        }
+
+        public override bool Equals(object obj)
+        {
+            if (ReferenceEquals(this, obj))
+                return true;
+
+            var other = obj as Repository;
+            return Equals(other);
+        }
+
+        public bool Equals(Repository other)
+        {
+            return Equals((IRepository)other);
+        }
+
+        public bool Equals(IRepository other)
+        {
+            if (ReferenceEquals(this, other))
+                return true;
+
+            return other != null && object.Equals(LocalPath, other.LocalPath);
+        }
+
         private void CheckBranchCacheEvent(CacheUpdateEvent cacheUpdateEvent)
         {
             var managedCache = cacheContainer.BranchCache;
@@ -339,36 +280,95 @@ private static bool ShouldRaiseCacheEvent(CacheUpdateEvent cacheUpdateEvent, IMa
             return raiseEvent;
         }
 
-        /// <summary>
-        /// Note: We don't consider CloneUrl a part of the hash code because it can change during the lifetime
-        /// of a repository. Equals takes care of any hash collisions because of this
-        /// </summary>
-        /// <returns></returns>
-        public override int GetHashCode()
+        private void CacheContainer_OnCacheInvalidated(CacheType cacheType)
         {
-            return LocalPath.GetHashCode();
+            switch (cacheType)
+            {
+                case CacheType.BranchCache:
+                    break;
+
+                case CacheType.GitLogCache:
+                    break;
+
+                case CacheType.GitStatusCache:
+                    break;
+
+                case CacheType.GitLocksCache:
+                    break;
+
+                case CacheType.GitUserCache:
+                    break;
+
+                default:
+                    throw new ArgumentOutOfRangeException(nameof(cacheType), cacheType, null);
+            }
         }
 
-        public override bool Equals(object obj)
+        private void CacheContainer_OnCacheUpdated(CacheType cacheType, DateTimeOffset offset)
         {
-            if (ReferenceEquals(this, obj))
-                return true;
+            var cacheUpdateEvent = new CacheUpdateEvent { UpdatedTimeString = offset.ToString() };
+            switch (cacheType)
+            {
+                case CacheType.BranchCache:
+                    HandleBranchCacheUpdatedEvent(cacheUpdateEvent);
+                    break;
 
-            var other = obj as Repository;
-            return Equals(other);
+                case CacheType.GitLogCache:
+                    HandleGitLogCacheUpdatedEvent(cacheUpdateEvent);
+                    break;
+
+                case CacheType.GitStatusCache:
+                    HandleGitStatusCacheUpdatedEvent(cacheUpdateEvent);
+                    break;
+
+                case CacheType.GitLocksCache:
+                    HandleGitLocksCacheUpdatedEvent(cacheUpdateEvent);
+                    break;
+
+                case CacheType.GitUserCache:
+                    break;
+
+                case CacheType.RepositoryInfoCache:
+                    HandleRepositoryInfoCacheUpdatedEvent(cacheUpdateEvent);
+                    break;
+
+                default:
+                    throw new ArgumentOutOfRangeException(nameof(cacheType), cacheType, null);
+            }
         }
 
-        public bool Equals(Repository other)
+        private void HandleRepositoryInfoCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
         {
-            return Equals((IRepository)other);
+            Logger.Trace("RepositoryInfoCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
+            CurrentBranchChanged?.Invoke(cacheUpdateEvent);
+            CurrentRemoteChanged?.Invoke(cacheUpdateEvent);
+            CurrentBranchAndRemoteChanged?.Invoke(cacheUpdateEvent);
         }
 
-        public bool Equals(IRepository other)
+        private void HandleGitLocksCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
         {
-            if (ReferenceEquals(this, other))
-                return true;
+            Logger.Trace("GitLocksCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
+            LocksChanged?.Invoke(cacheUpdateEvent);
+        }
 
-            return other != null && object.Equals(LocalPath, other.LocalPath);
+        private void HandleGitStatusCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
+        {
+            Logger.Trace("GitStatusCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
+            StatusChanged?.Invoke(cacheUpdateEvent);
+        }
+
+        private void HandleGitLogCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
+        {
+            Logger.Trace("GitLogCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
+            LogChanged?.Invoke(cacheUpdateEvent);
+        }
+
+        private void HandleBranchCacheUpdatedEvent(CacheUpdateEvent cacheUpdateEvent)
+        {
+            Logger.Trace("BranchCache Updated {0}", cacheUpdateEvent.UpdatedTimeString);
+            LocalBranchListChanged?.Invoke(cacheUpdateEvent);
+            RemoteBranchListChanged?.Invoke(cacheUpdateEvent);
+            LocalAndRemoteBranchListChanged?.Invoke(cacheUpdateEvent);
         }
 
         private void RepositoryManager_OnCurrentRemoteUpdated(ConfigRemote? remote)