Merge pull request #190 from github-for-unity/fixes/command-line-osx

Fix opening a command line window on mac

Author: StanleyGoldman

src/GitHub.Api/OutputProcessors/IProcessManager.cs

@@ -9,6 +9,6 @@ T Configure<T>(T processTask, string executableFileName, string arguments, NPath
             where T : IProcess;
         IProcess Reconnect(IProcess processTask, int i);
         CancellationToken CancellationToken { get; }
-        IProcess RunCommandLineWindow(NPath workingDirectory);
+        void RunCommandLineWindow(NPath workingDirectory);
     }
 }

src/GitHub.Api/OutputProcessors/ProcessManager.cs

@@ -57,10 +57,9 @@ public T Configure<T>(T processTask, string executableFileName, string arguments
             return processTask;
         }
 
-        public IProcess RunCommandLineWindow(NPath workingDirectory)
+        public void RunCommandLineWindow(NPath workingDirectory)
         {
-            var shell = environment.IsWindows ? "cmd" : environment.IsMac ? "xterm" : "sh";
-            var startInfo = new ProcessStartInfo(shell)
+            var startInfo = new ProcessStartInfo
             {
                 RedirectStandardInput = false,
                 RedirectStandardOutput = false,
@@ -69,11 +68,22 @@ public IProcess RunCommandLineWindow(NPath workingDirectory)
                 CreateNoWindow = false
             };
 
+            if (environment.IsWindows)
+            {
+                startInfo.FileName = "cmd";
+            }
+            else if (environment.IsMac)
+            {
+                startInfo.FileName = "open";
+                startInfo.Arguments = $"-a Terminal {workingDirectory}";
+            }
+            else
+            {
+                startInfo.FileName = "sh";
+            }
+
             gitEnvironment.Configure(startInfo, workingDirectory);
-            var p = new ProcessTask<string>(cancellationToken, new SimpleOutputProcessor());
-            p.Configure(startInfo);
-            p.Start();
-            return p;
+            Process.Start(startInfo);
         }
 
         public IProcess Reconnect(IProcess processTask, int pid)