Fixing the load of the terminal and logging default system path

Author: StanleyGoldman

src/GitHub.Api/OutputProcessors/ProcessManager.cs

@@ -87,7 +87,7 @@ public void RunCommandLineWindow(NPath workingDirectory)
             if (environment.IsWindows)
             {
                 startInfo.FileName = "cmd";
-                gitEnvironment.Configure(startInfo, workingDirectory);
+                gitEnvironment.Configure(startInfo, workingDirectory, environment.IsCustomGitExecutable);
             }
             else if (environment.IsMac)
             {
@@ -97,7 +97,7 @@ public void RunCommandLineWindow(NPath workingDirectory)
                 var envVarFile = NPath.GetTempFilename();
                 startInfo.FileName = "open";
                 startInfo.Arguments = $"-a Terminal {envVarFile}";
-                gitEnvironment.Configure(startInfo, workingDirectory);
+                gitEnvironment.Configure(startInfo, workingDirectory, environment.IsCustomGitExecutable);
 
                 var envVars = startInfo.EnvironmentVariables;
                 var scriptContents = new List<string> {
@@ -107,14 +107,17 @@ public void RunCommandLineWindow(NPath workingDirectory)
                 if (!environment.IsCustomGitExecutable) {
                     scriptContents.Add($"PATH=\"{envVars["GHU_FULLPATH"]}\" /bin/bash");
                 }
+                else {
+                    scriptContents.Add($"/bin/bash");
+                }
 
                 environment.FileSystem.WriteAllLines(envVarFile, scriptContents.ToArray());
                 Mono.Unix.Native.Syscall.chmod(envVarFile, (Mono.Unix.Native.FilePermissions)493); // -rwxr-xr-x mode (0755)
             }
             else
             {
                 startInfo.FileName = "sh";
-                gitEnvironment.Configure(startInfo, workingDirectory);
+                gitEnvironment.Configure(startInfo, workingDirectory, environment.IsCustomGitExecutable);
             }
 
             Process.Start(startInfo);

src/GitHub.Api/Platform/ProcessEnvironment.cs

@@ -22,6 +22,8 @@ public void Configure(ProcessStartInfo psi, NPath workingDirectory, bool dontSet
             psi.EnvironmentVariables["TMP"] = psi.EnvironmentVariables["TEMP"] = NPath.SystemTemp;
             psi.EnvironmentVariables["GHU_WORKINGDIR"] = workingDirectory;
 
+            
+            Logger.Trace("Default System PATH:{0}", Environment.GetEnvironmentVariable("PATH"));
             Logger.Trace("Configure DontSetupGit:{0}", dontSetupGit);
 
             // if we don't know where git is, then there's nothing else to configure