Properly controlling the activeView while the git path is loading on first run

Author: StanleyGoldman

src/GitHub.Api/Extensions/FileSystemExtensions.cs

@@ -41,6 +41,8 @@ public static string CalculateFolderMD5(this IFileSystem fileSystem, string path
         {
             //https://stackoverflow.com/questions/3625658/creating-hash-for-folder
 
+            Logging.Trace("Calculating MD5 for folder: {0}", path);
+
             var filePaths = fileSystem.GetFiles(path, "*", SearchOption.AllDirectories)
                 .OrderBy(p => p)
                 .ToArray();
@@ -62,6 +64,8 @@ public static string CalculateFolderMD5(this IFileSystem fileSystem, string path
                 //Handles empty filePaths case
                 md5.TransformFinalBlock(new byte[0], 0, 0);
 
+                Logging.Trace("Completed Calculating MD5 for folder: {0}", path);
+
                 return BitConverter.ToString(md5.Hash).Replace("-", "").ToLower();
             }
         }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs

@@ -23,6 +23,7 @@ public override void InitializeView(IView parent)
         {
             base.InitializeView(parent);
             gitExecutableIsSet = Environment.GitExecutablePath != null;
+            Redraw();
         }
 
         public override void OnEnable()

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/LoadingView.cs

@@ -18,7 +18,19 @@ public override void InitializeView(IView parent)
 
         public override void OnGUI()
         {
-            
+            GUILayout.BeginVertical();
+            {
+                GUILayout.FlexibleSpace();
+                GUILayout.BeginHorizontal();
+                {
+                    GUILayout.FlexibleSpace();
+                    GUILayout.Label(WindowTitle);
+                    GUILayout.FlexibleSpace();
+                }
+                GUILayout.EndHorizontal();
+                GUILayout.FlexibleSpace();
+            }
+            GUILayout.EndVertical();
         }
 
         public override bool IsBusy

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

@@ -23,8 +23,8 @@ class Window : BaseWindow
         private const string Window_RepoBranchTooltip = "Active branch";
 
         [NonSerialized] private double notificationClearTime = -1;
-        [SerializeField] private SubTab changeTab = SubTab.History;
-        [SerializeField] private SubTab activeTab = SubTab.History;
+        [SerializeField] private SubTab changeTab = SubTab.None;
+        [SerializeField] private SubTab activeTab = SubTab.None;
         [SerializeField] private InitProjectView initProjectView = new InitProjectView();
         [SerializeField] private LoadingView loadingView = new LoadingView();
         [SerializeField] private BranchesView branchesView = new BranchesView();
@@ -88,13 +88,27 @@ public override void Initialize(IApplicationManager applicationManager)
 
             gitExecutableIsSet = Environment.GitExecutablePath != null;
 
-            if (!gitExecutableIsSet && activeTab != SubTab.Loading)
+            if (ApplicationCache.Instance.FirstRun && !gitExecutableIsSet && activeTab != SubTab.Loading)
             {
                 changeTab = activeTab = SubTab.Loading;
             }
-            else if (!HasRepository && activeTab != SubTab.InitProject && activeTab != SubTab.Settings)
+            else if(gitExecutableIsSet)
             {
-                changeTab = activeTab = SubTab.InitProject;
+                if (HasRepository)
+                {
+                    if (activeTab == SubTab.Loading)
+                    {
+                        changeTab = SubTab.Changes;
+                        UpdateActiveTab();
+                    }
+                }
+                else
+                {
+                    if (activeTab != SubTab.InitProject && activeTab != SubTab.Settings)
+                    {
+                        changeTab = activeTab = SubTab.InitProject;
+                    }
+                }
             }
 
             LoadingView.InitializeView(this);
@@ -176,7 +190,7 @@ public override void OnUI()
         {
             base.OnUI();
 
-            if(gitExecutableIsSet)
+            if(ApplicationCache.Instance.FirstRun && gitExecutableIsSet || !ApplicationCache.Instance.FirstRun)
             { 
                 if (HasRepository)
                 {
@@ -384,6 +398,7 @@ private void SwitchView(Subview fromView, Subview toView)
 
             if (fromView != null)
                 fromView.OnDisable();
+
             toView.OnEnable();
             toView.OnDataUpdate();