Renaming some fields for clarity

Author: StanleyGoldman

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BranchesView.cs

@@ -110,9 +110,10 @@ private void HandleRepositoryBranchChangeEvent(string obj)
         public override void Refresh()
         {
             base.Refresh();
-            var historyView = ((Window)Parent).HistoryTab;
 
 #if ENABLE_BROADMODE
+            var historyView = ((Window)Parent).HistoryView;
+
             if (historyView.BroadMode)
                 historyView.Refresh();
             else
@@ -131,9 +132,9 @@ public void RefreshEmbedded()
 
         public override void OnGUI()
         {
-            var historyView = ((Window)Parent).HistoryTab;
-
 #if ENABLE_BROADMODE
+            var historyView = ((Window)Parent).HistoryView;
+
             if (historyView.BroadMode)
                 historyView.OnGUI();
             else

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cs

@@ -29,10 +29,10 @@ class Window : BaseWindow
         [NonSerialized] private double notificationClearTime = -1;
 
         [SerializeField] private SubTab activeTab = SubTab.History;
-        [SerializeField] private BranchesView branchesTab = new BranchesView();
-        [SerializeField] private ChangesView changesTab = new ChangesView();
-        [SerializeField] private HistoryView historyTab = new HistoryView();
-        [SerializeField] private SettingsView settingsTab = new SettingsView();
+        [SerializeField] private BranchesView branchesView = new BranchesView();
+        [SerializeField] private ChangesView changesView = new ChangesView();
+        [SerializeField] private HistoryView historyView = new HistoryView();
+        [SerializeField] private SettingsView settingsView = new SettingsView();
 
         [SerializeField] private string repoBranch;
         [SerializeField] private string repoUrl;
@@ -74,10 +74,10 @@ public override void Initialize(IApplicationManager applicationManager)
         {
             base.Initialize(applicationManager);
 
-            HistoryTab.InitializeView(this);
-            ChangesTab.InitializeView(this);
-            BranchesTab.InitializeView(this);
-            SettingsTab.InitializeView(this);
+            HistoryView.InitializeView(this);
+            ChangesView.InitializeView(this);
+            BranchesView.InitializeView(this);
+            SettingsView.InitializeView(this);
         }
 
         public override void OnEnable()
@@ -91,15 +91,15 @@ public override void OnEnable()
             // Set window title
             titleContent = new GUIContent(Title, Styles.SmallLogo);
 
-            if (ActiveTab != null)
-                ActiveTab.OnEnable();
+            if (ActiveView != null)
+                ActiveView.OnEnable();
         }
 
         public override void OnDisable()
         {
             base.OnDisable();
-            if (ActiveTab != null)
-                ActiveTab.OnDisable();
+            if (ActiveView != null)
+                ActiveView.OnDisable();
         }
 
         public override void OnDataUpdate()
@@ -120,8 +120,8 @@ public override void OnDataUpdate()
                 }
             }
 
-            if (ActiveTab != null)
-                ActiveTab.OnDataUpdate();
+            if (ActiveView != null)
+                ActiveView.OnDataUpdate();
         }
 
         public override void OnRepositoryChanged(IRepository oldRepository)
@@ -131,22 +131,22 @@ public override void OnRepositoryChanged(IRepository oldRepository)
             DetachHandlers(oldRepository);
             AttachHandlers(Repository);
 
-            if (ActiveTab != null)
-                ActiveTab.OnRepositoryChanged(oldRepository);
+            if (ActiveView != null)
+                ActiveView.OnRepositoryChanged(oldRepository);
         }
 
         public override void OnSelectionChange()
         {
             base.OnSelectionChange();
-            if (ActiveTab != null)
-                ActiveTab.OnSelectionChange();
+            if (ActiveView != null)
+                ActiveView.OnSelectionChange();
         }
 
         public override void Refresh()
         {
             base.Refresh();
-            if (ActiveTab != null)
-                ActiveTab.Refresh();
+            if (ActiveView != null)
+                ActiveView.Refresh();
             Repaint();
         }
 
@@ -162,9 +162,9 @@ public override void OnUI()
             DoToolbarGUI();
 
             // GUI for the active tab
-            if (ActiveTab != null)
+            if (ActiveView != null)
             {
-                ActiveTab.OnGUI();
+                ActiveView.OnGUI();
             }
         }
 
@@ -294,9 +294,9 @@ private void DoToolbarGUI()
                 }
                 if (EditorGUI.EndChangeCheck())
                 {
-                    var from = ActiveTab;
+                    var from = ActiveView;
                     activeTab = tab;
-                    SwitchView(from, ActiveTab);
+                    SwitchView(from, ActiveView);
                 }
 
                 GUILayout.FlexibleSpace();
@@ -384,27 +384,27 @@ private static SubTab TabButton(SubTab tab, string title, SubTab activeTab)
             return GUILayout.Toggle(activeTab == tab, title, EditorStyles.toolbarButton) ? tab : activeTab;
         }
 
-        public HistoryView HistoryTab
+        public HistoryView HistoryView
         {
-            get { return historyTab; }
+            get { return historyView; }
         }
 
-        public ChangesView ChangesTab
+        public ChangesView ChangesView
         {
-            get { return changesTab; }
+            get { return changesView; }
         }
 
-        public BranchesView BranchesTab
+        public BranchesView BranchesView
         {
-            get { return branchesTab; }
+            get { return branchesView; }
         }
 
-        public SettingsView SettingsTab
+        public SettingsView SettingsView
         {
-            get { return settingsTab; }
+            get { return settingsView; }
         }
 
-        private Subview ActiveTab
+        private Subview ActiveView
         {
             get
             {
@@ -417,14 +417,14 @@ private Subview ToView(SubTab tab)
             switch (tab)
             {
                 case SubTab.History:
-                    return historyTab;
+                    return historyView;
                 case SubTab.Changes:
-                    return changesTab;
+                    return changesView;
                 case SubTab.Branches:
-                    return branchesTab;
+                    return branchesView;
                 case SubTab.Settings:
                 default:
-                    return settingsTab;
+                    return settingsView;
             }
         }