Fix calling finally handlers and add regression test for it

Author: shana

src/GitHub.Api/Tasks/TaskBase.cs

@@ -639,6 +639,7 @@ protected virtual void RaiseOnEnd(TResult data)
         protected override void CallFinallyHandler()
         {
             finallyHandler?.Invoke(!taskFailed, result);
+            base.CallFinallyHandler();
         }
 
         public new Task<TResult> Task

src/tests/TaskSystemIntegrationTests/TaskSystem.csproj

@@ -38,6 +38,10 @@
       <HintPath>$(SolutionDir)\packages\AsyncBridge.Net35.0.2.3333.0\lib\net35-Client\AsyncBridge.Net35.dll</HintPath>
       <Private>True</Private>
     </Reference>
+    <Reference Include="FluentAssertions, Version=2.2.0.0, Culture=neutral, PublicKeyToken=33f2691a05b67b6a, processorArchitecture=MSIL">
+      <HintPath>..\..\..\packages\FluentAssertions.2.2.0.0\lib\net35\FluentAssertions.dll</HintPath>
+      <Private>True</Private>
+    </Reference>
     <Reference Include="NSubstitute, Version=1.10.0.0, Culture=neutral, PublicKeyToken=92dd2e9066daa5ca, processorArchitecture=MSIL">
       <HintPath>$(SolutionDir)\packages\NSubstitute.1.10.0.0\lib\net35\NSubstitute.dll</HintPath>
       <Private>True</Private>

src/tests/TaskSystemIntegrationTests/Tests.cs

@@ -10,11 +10,15 @@
 using NSubstitute;
 using GitHub.Logging;
 using System.Diagnostics;
+using System.Runtime.CompilerServices;
+using FluentAssertions;
 
 namespace IntegrationTests
 {
     class BaseTest
     {
+        protected const int Timeout = 30000;
+
         public BaseTest()
         {
             Logger = LogHelper.GetLogger(GetType());
@@ -75,6 +79,27 @@ public void Setup()
         public void Teardown()
         {
         }
+
+        protected void StartTest(out Stopwatch watch, out ILogging logger, [CallerMemberName] string testName = "test")
+        {
+            watch = new Stopwatch();
+            logger = LogHelper.GetLogger(testName);
+            logger.Trace("Starting test");
+        }
+
+        protected void StartTrackTime(Stopwatch watch, ILogging logger = null, string message = "")
+        {
+            if (!String.IsNullOrEmpty(message))
+                logger.Trace(message);
+            watch.Reset();
+            watch.Start();
+        }
+
+        protected void StopTrackTimeAndLog(Stopwatch watch, ILogging logger)
+        {
+            watch.Stop();
+            logger.Trace($"Time: {watch.ElapsedMilliseconds}");
+        }
     }
 
     [TestFixture]
@@ -617,11 +642,46 @@ public async Task ExceptionPropagatesOutIfNoFinally()
             await task.StartAsAsync();
         }
 
+        [Test]
+        public async Task AllFinallyHandlersAreCalledOnException()
+        {
+            Stopwatch watch;
+            ILogging logger;
+            StartTest(out watch, out logger);
+
+            var task = new FuncTask<string>(TaskManager.Token, () => { throw new InvalidOperationException(); });
+            bool exceptionThrown1, exceptionThrown2;
+            exceptionThrown1 = exceptionThrown2 = false;
+
+            task.Finally(success => exceptionThrown1 = !success);
+            task.Finally((success, _) => exceptionThrown2 = !success);
+
+            StartTrackTime(watch);
+            var waitTask = task.Start().Task;
+            var ret = await TaskEx.WhenAny(waitTask, TaskEx.Delay(Timeout));
+            StopTrackTimeAndLog(watch, logger);
+            Assert.AreEqual(ret, waitTask);
+
+            exceptionThrown1.Should().BeTrue();
+            exceptionThrown2.Should().BeTrue();
+        }
+
         [Test]
         public async Task StartAsyncWorks()
         {
+            Stopwatch watch;
+            ILogging logger;
+            StartTest(out watch, out logger);
+
             var task = new FuncTask<int>(Token, _ => 1);
-            var ret = await task.StartAsAsync();
+
+            StartTrackTime(watch);
+            var waitTask = task.StartAsAsync();
+            var retTask = await TaskEx.WhenAny(waitTask, TaskEx.Delay(Timeout));
+            StopTrackTimeAndLog(watch, logger);
+            Assert.AreEqual(retTask, waitTask);
+            var ret = await waitTask;
+
             Assert.AreEqual(1, ret);
         }
 

src/tests/TaskSystemIntegrationTests/packages.config

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
   <package id="AsyncBridge.Net35" version="0.2.3333.0" targetFramework="net35" />
+  <package id="FluentAssertions" version="2.2.0.0" targetFramework="net35" />
   <package id="NSubstitute" version="1.10.0.0" targetFramework="net35" />
   <package id="NUnit" version="2.6.4" targetFramework="net35" />
   <package id="NUnit.Runners" version="2.6.4" targetFramework="net35" />