Merge pull request #44 from github-for-unity/fixes/loading-resources

Loading resources was horribly horribly broken

Author: StanleyGoldman

src/GitHub.Api/Application/ApplicationManagerBase.cs

@@ -107,8 +107,8 @@ public ITask InitializeRepository()
                 .Then(GitClient.LfsInstall())
                 .ThenInUI(SetProjectToTextSerialization)
                 .Then(new ActionTask(CancellationToken, _ => {
-                    AssemblyResources.ToFile(ResourceType.Generic, ".gitignore", targetPath);
-                    AssemblyResources.ToFile(ResourceType.Generic, ".gitattributes", targetPath);
+                    AssemblyResources.ToFile(ResourceType.Generic, ".gitignore", targetPath, Environment);
+                    AssemblyResources.ToFile(ResourceType.Generic, ".gitattributes", targetPath, Environment);
 
                     assetsGitignore.CreateFile();
                 }))

src/GitHub.Api/Helpers/AssemblyResources.cs

@@ -12,7 +12,7 @@ enum ResourceType
 
     class AssemblyResources
     {
-        public static NPath ToFile(ResourceType resourceType, string resource, NPath destinationPath)
+        public static NPath ToFile(ResourceType resourceType, string resource, NPath destinationPath, IEnvironment environment)
         {
             var os = "";
             if (resourceType == ResourceType.Platform)
@@ -21,15 +21,15 @@ public static NPath ToFile(ResourceType resourceType, string resource, NPath des
                     : DefaultEnvironment.OnLinux ? "linux"
                         : "mac";
             }
-            var type = resourceType == ResourceType.Icon ? "Icons"
+            var type = resourceType == ResourceType.Icon ? "IconsAndLogos"
                 : resourceType == ResourceType.Platform ? "PlatformResources"
                 : "Resources";
             var stream = Assembly.GetExecutingAssembly().GetManifestResourceStream(
                                      String.Format("GitHub.Unity.{0}{1}.{2}", type, os != "" ? "." + os : os, resource));
             if (stream != null)
                 return destinationPath.Combine(resource).WriteAllBytes(stream.ToByteArray());
 
-            return new NPath(type).Combine(os, resource);
+            return environment.ExtensionInstallPath.Combine(type, os, resource);
         }
     }
 }

src/GitHub.Api/Installer/GitInstaller.cs

@@ -163,7 +163,7 @@ public Task<bool> SetupGitIfNeeded(NPath tempPath, IProgress<float> zipFileProgr
 
             cancellationToken.ThrowIfCancellationRequested();
 
-            var archiveFilePath = AssemblyResources.ToFile(ResourceType.Platform, GitZipFile, tempPath);
+            var archiveFilePath = AssemblyResources.ToFile(ResourceType.Platform, GitZipFile, tempPath, environment);
             if (!archiveFilePath.FileExists())
             {
                 logger.Warning("Archive \"{0}\" missing", archiveFilePath.ToString());
@@ -228,7 +228,7 @@ public Task<bool> SetupGitLfsIfNeeded(NPath tempPath, IProgress<float> zipFilePr
 
             cancellationToken.ThrowIfCancellationRequested();
 
-            var archiveFilePath = AssemblyResources.ToFile(ResourceType.Platform, GitLfsZipFile, tempPath);
+            var archiveFilePath = AssemblyResources.ToFile(ResourceType.Platform, GitLfsZipFile, tempPath, environment);
             if (!archiveFilePath.FileExists())
             {
                 logger.Warning("Archive \"{0}\" missing", archiveFilePath.ToString());

src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs

@@ -50,7 +50,7 @@ public IEnvironment Environment
                     {
                         unityAssetsPath = Application.dataPath;
                         unityApplication = EditorApplication.applicationPath;
-                        extensionInstallPath = AssetDatabase.GetAssetPath(this);
+                        extensionInstallPath = DetermineInstallationPath();
                         unityVersion = Application.unityVersion;
                     }
                     environment.Initialize(unityVersion, extensionInstallPath.ToNPath(), unityApplication.ToNPath(), unityAssetsPath.ToNPath());
@@ -62,6 +62,16 @@ public IEnvironment Environment
             }
         }
 
+        private NPath DetermineInstallationPath()
+        {
+            // Juggling to find out where we got installed
+            var shim = ScriptableObject.CreateInstance<RunLocationShim>();
+            var script = MonoScript.FromScriptableObject(shim);
+            var scriptPath = AssetDatabase.GetAssetPath(script).ToNPath();
+            ScriptableObject.DestroyImmediate(shim);
+            return scriptPath.Parent;
+        }
+
         public void Flush()
         {
             repositoryPath = Environment.RepositoryPath;