fix: much more stable, no longer panic based on out of bounds (#33)

Fixes #32 

- Trying to initiate autocomplete at coord 0 0
- Trying to initiate autocomplete in new file
- Having to match from start of title/login is painful

Author: AlexanderBrevig

Cargo.lock

@@ -52,7 +52,7 @@ impl Backend {
         let completion_items = self
             .issue_map
             .iter()
-            .filter(|issue| issue.title.starts_with(needle)) //TODO: smarter fuzzy match
+            .filter(|issue| issue.get_detail().contains(needle)) //TODO: smarter fuzzy match
             .map(|issue| CompletionItem {
                 label: issue.get_label(),
                 detail: Some(issue.get_detail()),
@@ -83,7 +83,7 @@ impl Backend {
         let completion_items = self
             .member_map
             .iter()
-            .filter(|member| member.login.starts_with(needle)) //TODO: smarter fuzzy match
+            .filter(|member| member.get_detail().contains(needle)) //TODO: smarter fuzzy match
             .map(|member| CompletionItem {
                 label: member.get_label(),
                 detail: Some(member.get_detail()),
@@ -114,7 +114,7 @@ impl Backend {
         let completion_items = self
             .wiki_map
             .iter()
-            .filter(|member| member.title.starts_with(needle)) //TODO: smarter fuzzy match
+            .filter(|member| member.title.contains(needle)) //TODO: smarter fuzzy match
             .map(|member| CompletionItem {
                 label: member.title.to_owned(),
                 detail: None,
@@ -146,7 +146,7 @@ impl Backend {
         let completion_items = self
             .repository_map
             .iter()
-            .filter(|repo| repo.name.starts_with(needle)) //TODO: smarter fuzzy match
+            .filter(|repo| repo.get_detail().contains(needle)) //TODO: smarter fuzzy match
             .map(|repo| CompletionItem {
                 label: repo.get_label(),
                 detail: Some(repo.get_detail()),
@@ -214,9 +214,9 @@ impl Backend {
 
     async fn initialize_repos_as(&self, affiliation: &str) {
         self.client
-            .log_message(
+            .show_message(
                 MessageType::INFO,
-                format!("initialize_repos_as: {}", affiliation),
+                format!("initializing repos with affiliation `{}`", affiliation),
             )
             .await;
         let mut page: u8 = 0;
@@ -254,7 +254,7 @@ impl Backend {
 
     async fn initialize_issues(&self) {
         self.client
-            .log_message(MessageType::INFO, "initialize_issues")
+            .show_message(MessageType::LOG, "initializing issues")
             .await;
         let mut page: u8 = 0;
         let mut issues: Vec<Issue> = vec![];
@@ -287,7 +287,7 @@ impl Backend {
 
     async fn initialize_wiki(&self) {
         self.client
-            .log_message(MessageType::INFO, "initialize_wiki")
+            .show_message(MessageType::INFO, "initializing wiki")
             .await;
         let wikis = gh::wiki::find_wiki_articles(&self.owner, &self.repo).await;
         match wikis {
@@ -305,7 +305,7 @@ impl Backend {
 
     async fn initialize_members(&self) {
         self.client
-            .log_message(MessageType::INFO, "initialize_members")
+            .show_message(MessageType::INFO, "initializing members")
             .await;
         let mut page: u8 = 0;
         let mut members: Vec<Author> = vec![];

src/backend.rs

@@ -22,9 +22,6 @@ impl LanguageServer for Backend {
                         })),
                     },
                 )),
-                // text_document_sync: Some(TextDocumentSyncCapability::Kind(
-                //     TextDocumentSyncKind::FULL,
-                // )),
                 completion_provider: Some(CompletionOptions {
                     resolve_provider: Some(false),
                     trigger_characters: Some(vec![
@@ -38,15 +35,16 @@ impl LanguageServer for Backend {
                     all_commit_characters: None,
                     ..Default::default()
                 }),
-                execute_command_provider: Some(ExecuteCommandOptions {
-                    commands: vec!["dummy.do_something".to_string()],
-                    work_done_progress_options: Default::default(),
-                }),
+                // execute_command_provider: Some(ExecuteCommandOptions {
+                //     commands: vec!["dummy.do_something".to_string()],
+                //     work_done_progress_options: Default::default(),
+                // }),
                 workspace: Some(WorkspaceServerCapabilities {
                     workspace_folders: Some(WorkspaceFoldersServerCapabilities {
                         supported: Some(true),
                         change_notifications: Some(OneOf::Left(true)),
                     }),
+
                     file_operations: None,
                 }),
                 ..ServerCapabilities::default()
@@ -57,9 +55,6 @@ impl LanguageServer for Backend {
 
     async fn initialized(&self, _: InitializedParams) {
         self.initialize().await;
-        self.client
-            .log_message(MessageType::INFO, "initialized!")
-            .await;
     }
 
     async fn shutdown(&self) -> Result<()> {
@@ -168,11 +163,17 @@ impl LanguageServer for Backend {
             .document_map
             .get(&uri.to_string())
             .ok_or(tower_lsp::jsonrpc::Error::invalid_request())?;
+
         let line = rope
             .get_line(position.line as usize)
-            .ok_or(tower_lsp::jsonrpc::Error::internal_error())?
-            .to_string();
-        let line = line.split_at(position.character as usize).0;
+            .ok_or(tower_lsp::jsonrpc::Error::internal_error())?;
+        let character_pos = if position.character as usize >= line.len_chars() {
+            line.len_chars() - 1
+        } else {
+            position.character as usize
+        };
+        let line = line.to_string();
+        let line = line.split_at(character_pos).0;
         let word = line
             .chars()
             .rev()
@@ -181,7 +182,11 @@ impl LanguageServer for Backend {
             .chars()
             .rev()
             .collect::<String>();
-        let parts = word.split_at(1);
+        let parts = if word.len() <= 1 {
+            (word.as_str(), "")
+        } else {
+            word.split_at(1)
+        };
         let completions = match parts.0 {
             "#" => self.search_issue_and_pr(position, parts.1).await,
             "@" => self.search_user(position, parts.1).await,