Skip to content

Commit 46ec92d

Browse files
committed
update lab3 with repo ruleset and screenshots
1 parent a875d9e commit 46ec92d

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

_labs/images/lab-3-2-2.png

86.6 KB
Loading

_labs/images/lab-3-2-3.png

-4.73 KB
Loading

_labs/images/lab-3-2-4.png

-95.3 KB
Binary file not shown.

_labs/lab3.md

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -95,26 +95,19 @@ Without a ruleset (GitHub's new version of branch protections), even though Code
9595
1. Give the ruleset a **name** (any name is fine)
9696
2. Change the **enforcement status** to **Active**.
9797
3. Under **target branches**, click **Add target** and select **Include default branch**.
98-
4. Scroll down and check the **Require status checks to pass** box
99-
5. Click on the **+ Add checks ▾** button
100-
6. Search for **CodeQL**. We should see a suggested **CodeQL** check show up with **GitHub Advanced Security** text to the right. Add it.
98+
4. Scroll down and check the **Require code scanning results** box
99+
5. The CodeQL tool should already be there - there's nothing to change
100+
5. Scroll down and click the **Create** button.
101101

102102
<details>
103103
<img src="images/lab-3-2-2.png"/>
104104
</details>
105105

106-
5. Let's also search for **Analyze**. We should see a **Analyze (javascript-typescript)** check show up. Add it.
107-
6. Scroll down and click the **Create** button.
108-
109-
<details>
110-
<img src="images/lab-3-2-3.png"/>
111-
</details>
112-
113106
7. With the ruleset created, both the JavaScript scan has to finish and no vulnerabilities found with CodeQL in order to merge the code.
114107
8. Navigate back to our open PR. The **Merge pull request** button should now be grayed out, preventing us from merging vulnerable code.
115108

116109
<details>
117-
<img src="images/lab-3-2-4.png"/>
110+
<img src="images/lab-3-2-3.png"/>
118111
</details>
119112

120113
9. Review the **Copilot Autofix suggestion** - it offers a similar suggestion to what Copilot in our IDE did!

0 commit comments

Comments
 (0)