Complete ESLint fixes - resolved 18 of 26 issues in shared workspace

Co-authored-by: chrisreddington <[email protected]>

Author: Copilot

shared/src/storage/mcp-api-client.ts

@@ -1,20 +1,20 @@
-import type { GameSession } from '../types/game'
-import type { TicTacToeGameState, RPSGameState } from '../types/games'
+import type { GameSession, Player } from '../types/game'
+import type { TicTacToeGameState, RPSGameState, TicTacToeMove, RPSMove } from '../types/games'
 import { httpGet, httpPost, WEB_API_BASE } from '../utils/http-client'
 
 // MCP-specific API functions that make HTTP calls to web app
 export async function getTicTacToeGameForMCP(gameId: string): Promise<GameSession<TicTacToeGameState> | undefined> {
   try {
     // Get all games and find the one we want
     const games = await httpGet(`${WEB_API_BASE}/api/games/tic-tac-toe`)
-    return games.find((game: any) => game.gameState?.id === gameId)
+    return games.find((game: GameSession<TicTacToeGameState>) => game.gameState?.id === gameId)
   } catch (error) {
     console.error('Error fetching tic-tac-toe game via API:', error)
     return undefined
   }
 }
 
-export async function createTicTacToeGameForMCP(players: any[]): Promise<GameSession<TicTacToeGameState>> {
+export async function createTicTacToeGameForMCP(players: Player[]): Promise<GameSession<TicTacToeGameState>> {
   try {
     const playerName = players.find(p => !p.isAI)?.name || 'Player'
     return await httpPost(`${WEB_API_BASE}/api/games/tic-tac-toe`, { playerName })
@@ -24,7 +24,7 @@ export async function createTicTacToeGameForMCP(players: any[]): Promise<GameSes
   }
 }
 
-export async function makeTicTacToeMove(gameId: string, move: any, playerId: string): Promise<GameSession<TicTacToeGameState>> {
+export async function makeTicTacToeMove(gameId: string, move: TicTacToeMove, playerId: string): Promise<GameSession<TicTacToeGameState>> {
   try {
     return await httpPost(`${WEB_API_BASE}/api/games/tic-tac-toe/${gameId}/move`, { move, playerId })
   } catch (error) {
@@ -36,14 +36,14 @@ export async function makeTicTacToeMove(gameId: string, move: any, playerId: str
 export async function getRPSGameForMCP(gameId: string): Promise<GameSession<RPSGameState> | undefined> {
   try {
     const games = await httpGet(`${WEB_API_BASE}/api/games/rock-paper-scissors/mcp`)
-    return games.find((game: any) => game.gameState?.id === gameId)
+    return games.find((game: GameSession<RPSGameState>) => game.gameState?.id === gameId)
   } catch (error) {
     console.error('Error fetching RPS game via API:', error)
     return undefined
   }
 }
 
-export async function makeRPSMove(gameId: string, move: any, playerId: string): Promise<GameSession<RPSGameState>> {
+export async function makeRPSMove(gameId: string, move: RPSMove, playerId: string): Promise<GameSession<RPSGameState>> {
   try {
     return await httpPost(`${WEB_API_BASE}/api/games/rock-paper-scissors/${gameId}/move`, { move, playerId })
   } catch (error) {

shared/src/testing/api-test-utils.ts

@@ -102,7 +102,7 @@ export function createMockGameSession<T extends BaseGameState>(gameState: T, gam
  * Use this to create consistent mocks across API route tests
  */
 export function createSharedGameMocks(gameClass: string): {
-  mockImplementation: any;
+  mockImplementation: Record<string, unknown>;
   mockGame: ReturnType<typeof createGameMock>;
 } {
   const mockGame = createGameMock()

shared/src/types/game.ts

@@ -19,7 +19,7 @@ export interface BaseGameState {
   updatedAt: Date;
 }
 
-export interface GameMove<T = any> {
+export interface GameMove<T = unknown> {
   playerId: PlayerId;
   move: T;
   timestamp: Date;
@@ -36,7 +36,7 @@ export interface Game<TGameState extends BaseGameState, TMove> {
   applyMove(gameState: TGameState, move: TMove, playerId: PlayerId): TGameState;
   checkGameEnd(gameState: TGameState): GameResult | null;
   getValidMoves(gameState: TGameState, playerId: PlayerId): TMove[];
-  getInitialState(players: Player[], options?: any): TGameState;
+  getInitialState(players: Player[], options?: Record<string, unknown>): TGameState;
 }
 
 // Generic game session for API communication

shared/src/utils/http-client.ts

@@ -15,7 +15,7 @@ export const WEB_API_BASE = process.env.WEB_API_BASE || 'http://localhost:3000'
  * @returns Promise resolving to the JSON response
  * @throws Error if the request fails or returns non-2xx status
  */
-export async function httpGet(url: string): Promise<any> {
+export async function httpGet<T = any>(url: string): Promise<T> {
   const response = await fetch(url)
   if (!response.ok) {
     throw new Error(`HTTP ${response.status}: ${response.statusText}`)
@@ -31,7 +31,7 @@ export async function httpGet(url: string): Promise<any> {
  * @returns Promise resolving to the JSON response
  * @throws Error if the request fails or returns non-2xx status
  */
-export async function httpPost(url: string, data: any): Promise<any> {
+export async function httpPost<T = any>(url: string, data: unknown): Promise<T> {
   const response = await fetch(url, {
     method: 'POST',
     headers: { 'Content-Type': 'application/json' },