Phase 1-2: Consolidate HTTP clients and remove dead code

Co-authored-by: chrisreddington <[email protected]>

Author: Copilot

mcp-server/package.json

@@ -2,12 +2,12 @@
   "name": "@turn-based-mcp/mcp-server",
   "version": "1.0.0",
   "description": "MCP server for turn-based games AI opponent",
-  "main": "dist/index.js",
+  "main": "dist/server.js",
   "type": "module",
   "scripts": {
     "build": "tsc",
     "dev": "tsc --watch",
-    "start": "node dist/index.js",
+    "start": "node dist/server.js",
     "clean": "rm -rf dist",
     "type-check": "tsc --noEmit",
     "test": "vitest run",

mcp-server/src/index.ts

@@ -1,28 +1,11 @@
 /**
  * HTTP client utilities for communicating with the web API
+ * 
+ * This module provides higher-level API functions for the MCP server
+ * while using shared HTTP utilities to eliminate code duplication.
  */
 
-const WEB_API_BASE = process.env.WEB_API_BASE || 'http://localhost:3000'
-
-export async function httpGet(url: string): Promise<any> {
-  const response = await fetch(url)
-  if (!response.ok) {
-    throw new Error(`HTTP ${response.status}: ${response.statusText}`)
-  }
-  return response.json()
-}
-
-export async function httpPost(url: string, data: any): Promise<any> {
-  const response = await fetch(url, {
-    method: 'POST',
-    headers: { 'Content-Type': 'application/json' },
-    body: JSON.stringify(data)
-  })
-  if (!response.ok) {
-    throw new Error(`HTTP ${response.status}: ${response.statusText}`)
-  }
-  return response.json()
-}
+import { httpGet, httpPost, WEB_API_BASE } from '@turn-based-mcp/shared'
 
 /**
  * Generic game state fetcher for resources

mcp-server/src/utils/http-client.ts

@@ -15,5 +15,5 @@
     "allowSyntheticDefaultImports": true
   },
   "include": ["src/**/*"],
-  "exclude": ["dist", "node_modules"]
+  "exclude": ["dist", "node_modules", "**/*.test.ts", "**/*.test.tsx"]
 }

mcp-server/tsconfig.json

@@ -1,29 +1,6 @@
 import type { GameSession } from '../types/game'
 import type { TicTacToeGameState, RPSGameState } from '../types/games'
-
-// Web app base URL for API calls (when called from MCP server)
-const WEB_API_BASE = process.env.WEB_API_BASE || 'http://localhost:3000'
-
-// HTTP client functions for MCP server
-async function httpGet(url: string): Promise<any> {
-  const response = await fetch(url)
-  if (!response.ok) {
-    throw new Error(`HTTP ${response.status}: ${response.statusText}`)
-  }
-  return response.json()
-}
-
-async function httpPost(url: string, data: any): Promise<any> {
-  const response = await fetch(url, {
-    method: 'POST',
-    headers: { 'Content-Type': 'application/json' },
-    body: JSON.stringify(data)
-  })
-  if (!response.ok) {
-    throw new Error(`HTTP ${response.status}: ${response.statusText}`)
-  }
-  return response.json()
-}
+import { httpGet, httpPost, WEB_API_BASE } from '../utils/http-client'
 
 // MCP-specific API functions that make HTTP calls to web app
 export async function getTicTacToeGameForMCP(gameId: string): Promise<GameSession<TicTacToeGameState> | undefined> {

shared/src/storage/mcp-api-client.ts

@@ -0,0 +1,44 @@
+/**
+ * Shared HTTP client utilities for communicating with the web API
+ * 
+ * Provides centralized HTTP functions to eliminate duplication between
+ * the MCP server and shared library API clients.
+ */
+
+// Web app base URL for API calls (configurable via environment)
+export const WEB_API_BASE = process.env.WEB_API_BASE || 'http://localhost:3000'
+
+/**
+ * Performs an HTTP GET request
+ * 
+ * @param url - The URL to fetch from
+ * @returns Promise resolving to the JSON response
+ * @throws Error if the request fails or returns non-2xx status
+ */
+export async function httpGet(url: string): Promise<any> {
+  const response = await fetch(url)
+  if (!response.ok) {
+    throw new Error(`HTTP ${response.status}: ${response.statusText}`)
+  }
+  return response.json()
+}
+
+/**
+ * Performs an HTTP POST request with JSON data
+ * 
+ * @param url - The URL to post to
+ * @param data - The data to send in the request body
+ * @returns Promise resolving to the JSON response
+ * @throws Error if the request fails or returns non-2xx status
+ */
+export async function httpPost(url: string, data: any): Promise<any> {
+  const response = await fetch(url, {
+    method: 'POST',
+    headers: { 'Content-Type': 'application/json' },
+    body: JSON.stringify(data)
+  })
+  if (!response.ok) {
+    throw new Error(`HTTP ${response.status}: ${response.statusText}`)
+  }
+  return response.json()
+}

shared/src/utils/http-client.ts

@@ -34,4 +34,7 @@ export function getGameDisplayName(gameType: GameType): string {
   }
 }
 
+// Re-export HTTP client utilities
+export * from './http-client';
+
 

shared/src/utils/index.ts

@@ -1,2 +1,14 @@
+/**
+ * Game Storage Re-export Module
+ * 
+ * This module provides backward compatibility by re-exporting all storage 
+ * functions from the shared library. This allows existing web application
+ * code to continue using storage functions via this path while the actual
+ * implementation is centralized in the shared package.
+ * 
+ * Purpose: Maintains API stability during the monorepo consolidation process.
+ * Future: Consider migrating imports to use @turn-based-mcp/shared directly.
+ */
+
 // Re-export from shared package for backward compatibility
 export * from '@turn-based-mcp/shared';