fix: refactor comment use case and GitHubRepository

Author: Adrià Manero

src/main/java/io/pakland/mdas/githubstats/application/external/FetchCommentsFromPullRequest.java

@@ -2,6 +2,8 @@
 
 import io.pakland.mdas.githubstats.application.exceptions.HttpException;
 import io.pakland.mdas.githubstats.domain.entity.Comment;
+import io.pakland.mdas.githubstats.domain.entity.PullRequest;
+import io.pakland.mdas.githubstats.domain.entity.Repository;
 import io.pakland.mdas.githubstats.domain.repository.CommentExternalRepository;
 
 import java.util.ArrayList;
@@ -14,16 +16,20 @@ public FetchCommentsFromPullRequest(CommentExternalRepository commentExternalRep
         this.commentExternalRepository = commentExternalRepository;
     }
 
-    public List<Comment> execute(
-            String repositoryOwner, String repositoryName, Integer pullRequestNumber)
-            throws HttpException {
-        int page = 1;
+    public List<Comment> execute(PullRequest pullRequest) throws HttpException {
+        Integer page = 1;
         List<Comment> commentList = new ArrayList<>();
-        int responseResults;
+        Integer responseResults;
+        Repository repository = pullRequest.getRepository();
         do {
-            List<Comment> apiResults = this.commentExternalRepository.fetchCommentsFromPullRequest(
-                    repositoryOwner, repositoryName, pullRequestNumber, page, 100
-            );
+            CommentExternalRepository.FetchCommentsFromPullRequestRequest request = CommentExternalRepository.FetchCommentsFromPullRequestRequest.builder()
+                    .repositoryOwner(repository.getOwnerLogin())
+                    .repositoryName(repository.getName())
+                    .pullRequestNumber(pullRequest.getNumber())
+                    .page(page)
+                    .perPage(100)
+                    .build();
+            List<Comment> apiResults = this.commentExternalRepository.fetchCommentsFromPullRequest(request);
             commentList.addAll(apiResults);
             responseResults = apiResults.size();
             page++;

src/main/java/io/pakland/mdas/githubstats/domain/repository/CommentExternalRepository.java

@@ -2,10 +2,26 @@
 
 import io.pakland.mdas.githubstats.application.exceptions.HttpException;
 import io.pakland.mdas.githubstats.domain.entity.Comment;
+import lombok.AllArgsConstructor;
+import lombok.Builder;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
 
 import java.util.List;
 
 public interface CommentExternalRepository {
-    public List<Comment> fetchCommentsFromPullRequest(
-            String repositoryOwner, String repositoryName, Integer pullRequestNumber, Integer page, Integer perPage) throws HttpException;
+
+    public List<Comment> fetchCommentsFromPullRequest(FetchCommentsFromPullRequestRequest request) throws HttpException;
+
+    @NoArgsConstructor
+    @AllArgsConstructor
+    @Builder
+    @Getter
+    public static class FetchCommentsFromPullRequestRequest {
+        private String repositoryOwner;
+        private String repositoryName;
+        private Integer pullRequestNumber;
+        private Integer page;
+        private Integer perPage;
+    }
 }

src/main/java/io/pakland/mdas/githubstats/infrastructure/github/repository/CommentGitHubRepository.java

@@ -6,7 +6,7 @@
 import io.pakland.mdas.githubstats.domain.lib.InternalCaching;
 import io.pakland.mdas.githubstats.domain.repository.CommentExternalRepository;
 import io.pakland.mdas.githubstats.infrastructure.github.model.GitHubCommentDTO;
-import java.util.*;
+import java.util.List;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.web.reactive.function.client.WebClientResponseException;
@@ -23,19 +23,18 @@ public CommentGitHubRepository(WebClientConfiguration webClientConfiguration) {
     }
 
     @Override
-    public List<Comment> fetchCommentsFromPullRequest(
-        String repositoryOwner, String repositoryName, Integer pullRequestNumber, Integer page,
-        Integer perPage)
+    public List<Comment> fetchCommentsFromPullRequest(FetchCommentsFromPullRequestRequest request)
         throws HttpException {
-        String query = String.format("/repos/%s/%s/pulls/%s/comments?%s", repositoryOwner,
-            repositoryName, pullRequestNumber, getRequestParams(page, perPage));
-        List<Comment> maybeResult = cache.get(query);
-        if (maybeResult != null) {
-            return maybeResult;
-        }
+        String query = String.format("/repos/%s/%s/pulls/%s/comments?%s",
+            request.getRepositoryOwner(),
+            request.getRepositoryName(),
+            request.getPullRequestNumber(),
+            getRequestParams(request.getPage(), request.getPerPage())
+        );
 
         try {
-            logger.info(" - Fetching comments from pull request: " + pullRequestNumber);
+            logger.info(
+                " - Fetching comments from pull request: " + request.getPullRequestNumber());
             List<Comment> result = this.webClientConfiguration.getWebClient().get()
                 .uri(query)
                 .retrieve()