Skip to content

Commit 0e4d800

Browse files
[Bugfix] Some Pull Requests/Issues/CommitBlocks are missing when generating release notes (#263)
* Updating name and version. * Fixing logic to get the right day of the release. * Implementing test.
1 parent ac8f1b9 commit 0e4d800

File tree

3 files changed

+766
-217
lines changed

3 files changed

+766
-217
lines changed

lib/src/Gren.js

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,11 +354,14 @@ class Gren {
354354
.filter((tag) => tag && this.options.ignoreTagsWith.every(ignoreTag => !tag.name.match(ignoreTag)))
355355
.map(tag => {
356356
const tagRelease = releases ? releases.filter(release => release.tag_name === tag.name)[0] : false;
357+
357358
const releaseId = tagRelease ? tagRelease.id : null;
359+
const releaseDate = tagRelease ? tagRelease.published_at : null;
358360

359361
return {
360362
tag: tag,
361-
releaseId: releaseId
363+
releaseId: releaseId,
364+
date: releaseDate
362365
};
363366
});
364367

@@ -1126,7 +1129,7 @@ class Gren {
11261129

11271130
this._validateRequiredTagsExists(tags, this.options.tags);
11281131

1129-
const releaseDates = this._sortReleasesByDate(await Promise.all(this._getTagDates(tags)));
1132+
const releaseDates = this._sortReleasesByDate(this._transformTagsIntoReleaseObjects(tags));
11301133
const selectedTags = (this._getSelectedTags(releaseDates) || (releaseDates.length > 1 ? [releaseDates[0], releaseDates[1]] : releaseDates));
11311134

11321135
loaded(`Tags found: ${selectedTags.map(({ name }) => name).join(', ')}`);
@@ -1136,6 +1139,14 @@ class Gren {
11361139
);
11371140
}
11381141

1142+
_transformTagsIntoReleaseObjects(tags) {
1143+
return tags.map(tag => ({
1144+
id: tag.releaseId,
1145+
name: tag.tag.name,
1146+
date: tag.date
1147+
}));
1148+
}
1149+
11391150
/**
11401151
* Check that the require tags exist in tags
11411152
*

0 commit comments

Comments
 (0)