Add more tests

Author: alexcanessa

lib/src/Gren.js

@@ -637,8 +637,12 @@ class Gren {
     _groupByLabel(issues) {
         const groups = [];
 
-        issues.forEach(issue => {
-            if (!issue.labels.length && this.options.template.noLabel) {
+        Object.values(ObjectAssign({}, issues)).forEach(issue => {
+            if (!issue.labels.length) {
+                if (!this.options.template.noLabel) {
+                    return;
+                }
+
                 issue.labels.push({name: this.options.template.noLabel});
             }
 
@@ -664,8 +668,9 @@ class Gren {
      *
      * @return {Array}
      */
-    _groupBy(issues) {
+    _groupBy(passedIssues) {
         const { groupBy } = this.options;
+        const issues = Object.values(ObjectAssign({}, passedIssues));
 
         if (!groupBy) {
             return issues.map(this._templateIssue.bind(this));
@@ -675,14 +680,14 @@ class Gren {
             return this._groupByLabel(issues);
         }
 
-        if (typeof groupBy !== 'object') {
+        if (typeof groupBy !== 'object' || Array.isArray(groupBy)) {
             throw chalk.red('The option for groupBy is invalid, please check the documentation');
         }
 
         const allLabels = Object.values(groupBy).reduce((carry, group) => carry.concat(group), []);
 
         const groups = Object.keys(groupBy).reduce((carry, group) => {
-            const groupIssues = Array.from(issues).filter(issue => {
+            const groupIssues = issues.filter(issue => {
                 if (!issue.labels.length && this.options.template.noLabel) {
                     issue.labels.push({name: this.options.template.noLabel});
                 }
@@ -759,7 +764,7 @@ class Gren {
         return this._getClosedIssues(releaseRanges)
             .then(issues => releaseRanges
                 .map(range => {
-                    const filteredIssues = issues
+                    const filteredIssues = Array.from(issues)
                         .filter(this._filterIssue.bind(this))
                         .filter(this._filterBlockIssue.bind(this, range));
                     const body = (!range[0].body || this.options.override) && this._groupBy(filteredIssues);

test/Gren.spec.js

@@ -115,10 +115,11 @@ describe('Gren', () => {
 
         describe('_groupBy, _groupByLabel', () => {
             it('Should return the just templated issues', () => {
-                const { normal } = issues;
+                const { normal, noLabel } = issues;
 
                 gren.options.groupBy = false;
                 assert.deepEqual(gren._groupBy(normal), [normal[0].title], 'The groupBy option is false');
+                assert.deepEqual(gren._groupBy(noLabel), [noLabel[0].title], 'The groupBy option is false');
             });
 
             it('Should return the group based on issue labels', () => {
@@ -129,9 +130,34 @@ describe('Gren', () => {
                 assert.deepEqual(gren._groupBy(noLabel), [`closed\n${noLabel[0].title}`], 'Group option is "label" with no labels');
             });
 
+            it('Should not return labels without labels', () => {
+                const { normal, noLabel } = issues;
+
+                gren.options.template.noLabel = false;
+                gren.options.groupBy = 'label';
+
+                assert.lengthOf(gren._groupBy(noLabel), 0, 'When the noLabel is false and only an issue with no labels has been passed');
+                assert.lengthOf(gren._groupBy(noLabel.concat(normal)), 1, 'When the noLabel is false and only one issue with labels has been passed');
+            });
+
+            it('Should throw an error', () => {
+                const error = chalk.red('The option for groupBy is invalid, please check the documentation');
+
+                gren.options.groupBy = 'an unrecognised string';
+                assert.throws(gren._groupBy.bind(gren, issues), error, 'Passing an unrecognised string');
+
+                gren.options.groupBy = [1, 2, 3];
+                assert.throws(gren._groupBy.bind(gren, issues), error, 'Passing an Array');
+
+                gren.options.groupBy = 123;
+                assert.throws(gren._groupBy.bind(gren, issues), error, 'Passing a number');
+            });
+
             it('Should group the issues based on the option', () => {
                 const { normal, noLabel } = issues;
 
+                gren.options.template.noLabel = 'closed';
+
                 gren.options.groupBy = {
                     'Test': ['enhancement'],
                     'Others': ['closed']