Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 0232915

Browse files
committed
Lazy load IDialogService in GitHubHomeSection.
To prevent `GitHub.App` being loaded when Team Explorer shown.
1 parent 5451416 commit 0232915

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/GitHub.TeamFoundation.14/Home/GitHubHomeSection.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public class GitHubHomeSection : TeamExplorerSectionBase, IGitHubHomeSection
3232
readonly ITeamExplorerServices teamExplorerServices;
3333
readonly IPackageSettings settings;
3434
readonly IUsageTracker usageTracker;
35-
readonly IDialogService dialogService;
3635

3736
[ImportingConstructor]
3837
public GitHubHomeSection(IGitHubServiceProvider serviceProvider,
@@ -41,8 +40,7 @@ public GitHubHomeSection(IGitHubServiceProvider serviceProvider,
4140
IVisualStudioBrowser visualStudioBrowser,
4241
ITeamExplorerServices teamExplorerServices,
4342
IPackageSettings settings,
44-
IUsageTracker usageTracker,
45-
IDialogService dialogService)
43+
IUsageTracker usageTracker)
4644
: base(serviceProvider, apiFactory, holder)
4745
{
4846
Title = "GitHub";
@@ -52,7 +50,6 @@ public GitHubHomeSection(IGitHubServiceProvider serviceProvider,
5250
this.teamExplorerServices = teamExplorerServices;
5351
this.settings = settings;
5452
this.usageTracker = usageTracker;
55-
this.dialogService = dialogService;
5653

5754
var openOnGitHub = ReactiveCommand.Create();
5855
openOnGitHub.Subscribe(_ => DoOpenOnGitHub());
@@ -118,6 +115,7 @@ static Octicon GetIcon(bool isPrivate, bool isHosted, bool isFork)
118115

119116
public void Login()
120117
{
118+
var dialogService = ServiceProvider.GetService<IDialogService>();
121119
dialogService.ShowLoginDialog();
122120
}
123121

0 commit comments

Comments
 (0)