Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 0265e86

Browse files
authored
Merge pull request #676 from github/backport/fixes/634-update-button-style
Backport #634 into 2.1.0.
2 parents 650a79d + d038756 commit 0265e86

File tree

6 files changed

+24
-14
lines changed

6 files changed

+24
-14
lines changed

src/GitHub.VisualStudio.UI/Resources.Designer.cs

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/GitHub.VisualStudio.UI/Resources.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,9 @@
333333
<data name="filterBranchesText" xml:space="preserve">
334334
<value>Filter branches</value>
335335
</data>
336+
<data name="PublishToGitHubButton" xml:space="preserve">
337+
<value>Publish to GitHub</value>
338+
</data>
336339
<data name="GetStartedLink" xml:space="preserve">
337340
<value>Get Started</value>
338341
</data>

src/GitHub.VisualStudio.UI/Styles/ThemeBlue.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
<SolidColorBrush x:Key="GitHubPrimaryOrangeBrush" Color="#FFC9510C" />
2424

2525
<SolidColorBrush x:Key="GitHubButtonBackgroundBrush" Color="#FFECECF1" />
26-
<SolidColorBrush x:Key="GitHubButtonBackgroundMouseOverBrush" Color="#FFDDDDE6" />
26+
<SolidColorBrush x:Key="GitHubButtonBackgroundMouseOverBrush" Color="#FFFFFF" />
2727
<SolidColorBrush x:Key="GitHubButtonBackgroundPressedBrush" Color="#FFCFCFDB" />
2828
<SolidColorBrush x:Key="GitHubButtonBackgroundDisabledBrush" Color="#FFFCFCFC" />
29-
<SolidColorBrush x:Key="GitHubButtonForegroundBrush" Color="#FF666666" />
29+
<SolidColorBrush x:Key="GitHubButtonForegroundBrush" Color="#1E1E1E" />
3030
<SolidColorBrush x:Key="GitHubButtonBorderBrush" Color="#FFCACACA" />
3131
<SolidColorBrush x:Key="GitHubButtonBorderMouseOverBrush" Color="#FFCACACA" />
3232
<SolidColorBrush x:Key="GitHubButtonBorderPressedBrush" Color="#FFBFBFBF" />

src/GitHub.VisualStudio.UI/Styles/ThemeDark.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
<SolidColorBrush x:Key="GitHubPrimaryOrangeBrush" Color="#FFC9510C" />
2424

2525
<SolidColorBrush x:Key="GitHubButtonBackgroundBrush" Color="#FF3F404B" />
26-
<SolidColorBrush x:Key="GitHubButtonBackgroundMouseOverBrush" Color="#FF4B4C59" />
26+
<SolidColorBrush x:Key="GitHubButtonBackgroundMouseOverBrush" Color="#54545C" />
2727
<SolidColorBrush x:Key="GitHubButtonBackgroundPressedBrush" Color="#FF2F3038" />
2828
<SolidColorBrush x:Key="GitHubButtonBackgroundDisabledBrush" Color="#FF3F404B" Opacity="0.3"/>
2929
<SolidColorBrush x:Key="GitHubButtonForegroundBrush" Color="#FFF1F1F1" />
3030
<SolidColorBrush x:Key="GitHubButtonBorderBrush" Color="#FF464646" />
31-
<SolidColorBrush x:Key="GitHubButtonBorderMouseOverBrush" Color="#FF595959" />
31+
<SolidColorBrush x:Key="GitHubButtonBorderMouseOverBrush" Color="#65656F" />
3232
<SolidColorBrush x:Key="GitHubButtonBorderPressedBrush" Color="#FF2F3038" />
3333

3434
<SolidColorBrush x:Key="GitHubPrimaryButtonBackgroundBrush" Color="#FF709946" />

src/GitHub.VisualStudio.UI/Styles/ThemeLight.xaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
<SolidColorBrush x:Key="GitHubPrimaryOrangeBrush" Color="#FFC9510C" />
2424

2525
<SolidColorBrush x:Key="GitHubButtonBackgroundBrush" Color="#FFECECF1" />
26-
<SolidColorBrush x:Key="GitHubButtonBackgroundMouseOverBrush" Color="#FFDDDDE6" />
26+
<SolidColorBrush x:Key="GitHubButtonBackgroundMouseOverBrush" Color="#CADEF4" />
2727
<SolidColorBrush x:Key="GitHubButtonBackgroundPressedBrush" Color="#FFCFCFDB" />
2828
<SolidColorBrush x:Key="GitHubButtonBackgroundDisabledBrush" Color="#FFFCFCFC" />
29-
<SolidColorBrush x:Key="GitHubButtonForegroundBrush" Color="#FF666666" />
30-
<SolidColorBrush x:Key="GitHubButtonBorderBrush" Color="#FFCACACA" />
31-
<SolidColorBrush x:Key="GitHubButtonBorderMouseOverBrush" Color="#FFCACACA" />
29+
<SolidColorBrush x:Key="GitHubButtonForegroundBrush" Color="#1E1E1E" />
30+
<SolidColorBrush x:Key="GitHubButtonBorderBrush" Color="#D1D3DE" />
31+
<SolidColorBrush x:Key="GitHubButtonBorderMouseOverBrush" Color="#D1D3DE" />
3232
<SolidColorBrush x:Key="GitHubButtonBorderPressedBrush" Color="#FFBFBFBF" />
3333

3434
<SolidColorBrush x:Key="GitHubPrimaryButtonBackgroundBrush" Color="#FF7ED321" />

src/GitHub.VisualStudio.UI/UI/Views/GitHubInvitationContent.xaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
mc:Ignorable="d"
1010
DataContext="{Binding ViewModel}" d:DesignWidth="230" d:DesignHeight="120"
1111
KeyboardNavigation.TabNavigation="Local"
12-
Background="{DynamicResource GitHubVsToolWindowBackground}"
13-
>
12+
Background="{DynamicResource GitHubVsToolWindowBackground}">
1413

1514
<UserControl.Style>
1615
<Style TargetType="{x:Type UserControl}">
@@ -30,6 +29,7 @@
3029
<cache:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI;component/SharedDictionary.xaml" />
3130
</ResourceDictionary.MergedDictionaries>
3231
<ui:BooleanToVisibilityConverter x:Key="BooleanToVisibilityConverter" />
32+
<Style x:Key="VSStyledButton" BasedOn="{StaticResource VsButtonStyleKey}" TargetType="{x:Type Button}"/>
3333
</ResourceDictionary>
3434
</UserControl.Resources>
3535

@@ -74,9 +74,7 @@
7474
Foreground="{DynamicResource GitHubVsToolWindowText}" />
7575
<Button Grid.Column="2" KeyboardNavigation.TabIndex="1" Style="{StaticResource ActionLinkButton}" HorizontalAlignment="Left" x:Name="signup" Click="signup_Click" Content="{x:Static prop:Resources.SignUpLink}"
7676
Visibility="{Binding ShowSignup, Converter={StaticResource BooleanToVisibilityConverter}}"/>
77-
<Button Grid.Column="3" KeyboardNavigation.TabIndex="2" Style="{StaticResource ActionLinkButton}" HorizontalAlignment="Right" x:Name="connect" Click="connect_Click" Content="{x:Static prop:Resources.GetStartedLink}"
78-
Visibility="{Binding ShowGetStarted, Converter={StaticResource BooleanToVisibilityConverter}}"/>
79-
<Rectangle Grid.Column="4" Width="16" Height="16" Margin="8,0,0,0" Fill="{StaticResource ConnectArrowBrush}"
77+
<Button Grid.Column="3" KeyboardNavigation.TabIndex="2" Style="{DynamicResource GitHubVsButton}" HorizontalAlignment="Right" x:Name="connect" Click="connect_Click" Content="{x:Static prop:Resources.PublishToGitHubButton}"
8078
Visibility="{Binding ShowGetStarted, Converter={StaticResource BooleanToVisibilityConverter}}"/>
8179
</Grid>
8280

0 commit comments

Comments
 (0)