Add first test for TippingService

Author: jcansdale

…vices.Vssdk/Services/VsTippingService.cs …ervices.Vssdk/Services/TippingService.cssrc/GitHub.Services.Vssdk/Services/VsTippingService.cs renamed to src/GitHub.Services.Vssdk/Services/TippingService.cs src/GitHub.Services.Vssdk/Services/VsTippingService.cs renamed to src/GitHub.Services.Vssdk/Services/TippingService.cs

@@ -3,13 +3,17 @@
 using System.Reflection;
 using System.Runtime.InteropServices;
 using System.Windows;
+using GitHub.Logging;
 using Microsoft;
+using Serilog;
 using IServiceProvider = System.IServiceProvider;
 
 namespace GitHub.Services.Vssdk.Services
 {
     public class TippingService : ITippingService
     {
+        static readonly ILogger log = LogManager.ForContext<TippingService>();
+
         // This is the only supported ClientId
         readonly Guid ClientId = new Guid("D5D3B674-05BB-4942-B8EC-C3D13B5BD6EE");
 
@@ -24,7 +28,8 @@ public void RequestCalloutDisplay(Guid calloutId, string title, string message,
             bool isPermanentlyDismissible, FrameworkElement targetElement,
             Guid vsCommandGroupId, uint vsCommandId)
         {
-            var screenPoint = targetElement.PointToScreen(new Point(targetElement.ActualWidth / 2, 0));
+            var screenPoint = !Splat.ModeDetector.InUnitTestRunner() ?
+                    targetElement.PointToScreen(new Point(targetElement.ActualWidth / 2, 0)) : default;
             var point = new Microsoft.VisualStudio.OLE.Interop.POINT { x = (int)screenPoint.X, y = (int)screenPoint.Y };
             RequestCalloutDisplay(ClientId, calloutId, title, message, isPermanentlyDismissible,
                 point, vsCommandGroupId, vsCommandId);
@@ -50,6 +55,12 @@ void RequestCalloutDisplay(Guid clientId, Guid calloutId, string title, string m
             Microsoft.VisualStudio.OLE.Interop.POINT anchor, Guid vsCommandGroupId, uint vsCommandId)
         {
             var tippingService = serviceProvider.GetService(typeof(SVsTippingService));
+            if (tippingService == null)
+            {
+                log.Error("Can't find {ServiceType}", typeof(SVsTippingService));
+                return;
+            }
+
             Assumes.Present(tippingService);
             var currentMethod = MethodBase.GetCurrentMethod();
             var parameterTypes = currentMethod.GetParameters().Select(p => p.ParameterType).ToArray();

test/GitHub.Services.Vssdk.UnitTests/GitHub.Services.Vssdk.UnitTests.csproj

@@ -6,6 +6,7 @@
 
   <ItemGroup>
     <Compile Include="..\Helpers\GlobalSuppressions.cs" Link="GlobalSuppressions.cs" />
+    <Compile Include="..\Helpers\SplatModeDetectorSetUp.cs" Link="SplatModeDetectorSetUp.cs" />
   </ItemGroup>
 
   <ItemGroup>

test/GitHub.Services.Vssdk.UnitTests/TippingServiceTests.cs

@@ -0,0 +1,20 @@
+using System;
+using NUnit.Framework;
+using GitHub.Services.Vssdk.Services;
+using NSubstitute;
+
+public class TippingServiceTests
+{
+    public class TheRequestCalloutDisplayMethod
+    {
+        [Test]
+        public void No_Exception_When_Cant_Find_SVsTippingService()
+        {
+            var serviceProvider = Substitute.For<IServiceProvider>();
+            var target = new TippingService(serviceProvider);
+
+            Assert.DoesNotThrow(() =>
+                target.RequestCalloutDisplay(Guid.Empty, "title", "message", true, null, Guid.Empty, 0));
+        }
+    }
+}