Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 0af2495

Browse files
Addressing some feedback
1 parent 84c6b3d commit 0af2495

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/GitHub.App/ViewModels/GitHubPane/PullRequestAnnotationsViewModel.cs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ public class PullRequestAnnotationsViewModel : PanePageViewModelBase, IPullReque
2020
{
2121
private readonly IPullRequestSessionManager sessionManager;
2222

23-
IPullRequestSession session;
2423
string title;
2524
string checkSuiteName;
2625
string checkRunName;
@@ -57,8 +56,8 @@ public async Task InitializeAsync(ILocalRepositoryModel localRepository, IConnec
5756
RemoteRepositoryOwner = owner;
5857
PullRequestNumber = pullRequestNumber;
5958
CheckRunId = checkRunId;
60-
session = await sessionManager.GetSession(owner, repo, pullRequestNumber);
61-
await Load(session.PullRequest);
59+
var session = await sessionManager.GetSession(owner, repo, pullRequestNumber);
60+
Load(session.PullRequest);
6261
}
6362
finally
6463
{
@@ -109,19 +108,18 @@ public IReadOnlyList<IPullRequestAnnotationItemViewModel> Annotations
109108
private set { this.RaiseAndSetIfChanged(ref annotations, value); }
110109
}
111110

112-
async Task Load(PullRequestDetailModel pullRequest)
111+
void Load(PullRequestDetailModel pullRequest)
113112
{
114113
IsBusy = true;
115114

116115
try
117116
{
118-
await Task.Delay(0);
119117
PullRequestTitle = pullRequest.Title;
120118

121119
var checkSuiteRun = pullRequest
122120
.CheckSuites.SelectMany(checkSuite => checkSuite.CheckRuns
123121
.Select(checkRun => new{checkSuite, checkRun}))
124-
.First(arg => arg.checkRun.DatabaseId == CheckRunId);
122+
.First(arg => arg.checkRun.Name == CheckRunName);
125123

126124
CheckSuiteName = checkSuiteRun.checkSuite.ApplicationName;
127125
CheckRunName = checkSuiteRun.checkRun.Name;

0 commit comments

Comments
 (0)