Fix CA errors on CheckBindingPathsAsync

jcansdale · jcansdale · commit 0cb34010d3c1 · 2018-10-23T19:01:55.000+01:00
diff --git a/src/GitHub.VisualStudio/GitHubPackage.cs b/src/GitHub.VisualStudio/GitHubPackage.cs
@@ -180,9 +180,9 @@ protected override async Task InitializeAsync(CancellationToken cancellationToke
             AddService(typeof(IPackageSettings), CreateService, true);
         }
 
+#if DEBUG
         async Task CheckBindingPathsAsync()
         {
-#if DEBUG
             try
             {
                 // When running in the Exp instance, ensure there is only one active binding path.
@@ -195,10 +195,10 @@ async Task CheckBindingPathsAsync()
             {
                 log.Error(e, nameof(CheckBindingPathsAsync));
             }
+        }
 #else
-            return Task.CompletedTask;
+        Task CheckBindingPathsAsync() => Task.CompletedTask;
 #endif
-        }
 
         public async Task<IGitHubPaneViewModel> ShowGitHubPane()
         {

Original file line number	Diff line number	Diff line change
`@@ -180,9 +180,9 @@ protected override async Task InitializeAsync(CancellationToken cancellationToke`
`180`	`180`	`AddService(typeof(IPackageSettings), CreateService, true);`
`181`	`181`	`}`
`182`	`182`
	`183`	`+#if DEBUG`
`183`	`184`	`async Task CheckBindingPathsAsync()`
`184`	`185`	`{`
`185`		`-#if DEBUG`
`186`	`186`	`try`
`187`	`187`	`{`
`188`	`188`	`// When running in the Exp instance, ensure there is only one active binding path.`
`@@ -195,10 +195,10 @@ async Task CheckBindingPathsAsync()`
`195`	`195`	`{`
`196`	`196`	`log.Error(e, nameof(CheckBindingPathsAsync));`
`197`	`197`	`}`
	`198`	`+ }`
`198`	`199`	`#else`
`199`		`- return Task.CompletedTask;`
	`200`	`+ Task CheckBindingPathsAsync() => Task.CompletedTask;`
`200`	`201`	`#endif`
`201`		`- }`
`202`	`202`
`203`	`203`	`public async Task<IGitHubPaneViewModel> ShowGitHubPane()`
`204`	`204`	`{`