Display login failues in TE connect pane.

When a login error occurs, display a message in our Team Explorer Connect pane with a Rety and Sign Out button.

Author: grokys

src/GitHub.App/SampleData/SampleViewModels.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.ComponentModel;
 using System.Diagnostics.CodeAnalysis;
 using System.Reactive;
 using System.Threading.Tasks;
@@ -201,8 +202,15 @@ class Conn : IConnection
 
             public Octokit.User User => null;
             public bool IsLoggedIn => true;
+            public bool IsLoggingIn => false;
 
             public Exception ConnectionError => null;
+
+            event PropertyChangedEventHandler INotifyPropertyChanged.PropertyChanged
+            {
+                add { }
+                remove { }
+            }
         }
 
         public RepositoryPublishViewModelDesigner()
@@ -421,12 +429,21 @@ public void Login()
         {
         }
 
+        public void Retry()
+        {
+        }
+
         public bool OpenRepository()
         {
             return true;
         }
 
+        public string ErrorMessage { get; set; }
         public IConnection SectionConnection { get; }
+        public bool IsLoggingIn { get; set; }
+        public bool ShowLogin { get; set; }
+        public bool ShowLogout { get; set; }
+        public bool ShowRetry { get; set; }
         public ICommand Clone { get; }
     }
 

src/GitHub.Exports/Models/IConnection.cs

@@ -1,4 +1,6 @@
 using System;
+using System.ComponentModel;
+using System.Threading.Tasks;
 using GitHub.Primitives;
 using Octokit;
 
@@ -7,7 +9,7 @@ namespace GitHub.Models
     /// <summary>
     /// Represents a configured connection to a GitHub account.
     /// </summary>
-    public interface IConnection
+    public interface IConnection : INotifyPropertyChanged
     {
         /// <summary>
         /// Gets the host address of the GitHub instance.
@@ -32,6 +34,11 @@ public interface IConnection
         /// </summary>
         bool IsLoggedIn { get; }
 
+        /// <summary>
+        /// Gets a value indicating whether a login is currently being attempted on the connection.
+        /// </summary>
+        bool IsLoggingIn { get; }
+
         /// <summary>
         /// Gets the exception that occurred when trying to log in, if <see cref="IsLoggedIn"/> is
         /// false.

src/GitHub.Exports/Services/Connection.cs

@@ -1,4 +1,6 @@
 using System;
+using System.ComponentModel;
+using System.Runtime.CompilerServices;
 using GitHub.Models;
 using GitHub.Primitives;
 
@@ -9,31 +11,102 @@ namespace GitHub.Services
     /// </summary>
     public class Connection : IConnection
     {
+        string username;
+        Octokit.User user;
+        bool isLoggedIn;
+        bool isLoggingIn;
+        Exception connectionError;
+
+        public Connection(HostAddress hostAddress)
+        {
+            HostAddress = hostAddress;
+            isLoggedIn = false;
+            isLoggingIn = true;
+        }
+
         public Connection(
             HostAddress hostAddress,
-            string userName,
-            Octokit.User user,
-            Exception connectionError)
+            string username,
+            Octokit.User user)
         {
             HostAddress = hostAddress;
-            Username = userName;
-            User = user;
-            ConnectionError = connectionError;
+            this.username = username;
+            this.user = user;
+            isLoggedIn = true;
         }
 
         /// <inheritdoc/>
         public HostAddress HostAddress { get; }
 
         /// <inheritdoc/>
-        public string Username { get; }
+        public string Username
+        {
+            get => username;
+            private set => RaiseAndSetIfChanged(ref username, value);
+        }
 
         /// <inheritdoc/>
-        public Octokit.User User { get; }
+        public Octokit.User User
+        {
+            get => user;
+            private set => RaiseAndSetIfChanged(ref user, value);
+        }
+
+        /// <inheritdoc/>
+        public bool IsLoggedIn
+        {
+            get => isLoggedIn;
+            private set => RaiseAndSetIfChanged(ref isLoggedIn, value);
+        }
 
         /// <inheritdoc/>
-        public bool IsLoggedIn => ConnectionError == null;
+        public bool IsLoggingIn
+        {
+            get => isLoggingIn;
+            private set => RaiseAndSetIfChanged(ref isLoggingIn, value);
+        }
 
         /// <inheritdoc/>
-        public Exception ConnectionError { get; }
+        public Exception ConnectionError
+        {
+            get => connectionError;
+            private set => RaiseAndSetIfChanged(ref connectionError, value);
+        }
+
+        /// <inheritdoc/>
+        public event PropertyChangedEventHandler PropertyChanged;
+
+        public void SetLoggingIn()
+        {
+            ConnectionError = null;
+            IsLoggedIn = false;
+            IsLoggingIn = true;
+            User = null;
+            Username = null;
+        }
+
+        public void SetError(Exception e)
+        {
+            ConnectionError = e;
+            IsLoggingIn = false;
+            IsLoggedIn = false;
+        }
+
+        public void SetSuccess(Octokit.User user)
+        {
+            User = user;
+            Username = user.Login;
+            IsLoggingIn = false;
+            IsLoggedIn = true;
+        }
+
+        void RaiseAndSetIfChanged<T>(ref T field, T value, [CallerMemberName] string propertyName = null)
+        {
+            if (!Equals(field, value))
+            {
+                field = value;
+                PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
+            }
+        }
     }
 }

src/GitHub.Exports/Services/IConnectionManager.cs

@@ -92,5 +92,12 @@ public interface IConnectionManager
         /// <param name="address"></param>
         /// <returns>A task tracking the operation.</returns>
         Task LogOut(HostAddress address);
+
+        /// <summary>
+        /// Retries logging in to a failed connection.
+        /// </summary>
+        /// <param name="connection">The connection.</param>
+        /// <returns>The resulting connection.</returns>
+        Task Retry(IConnection connection);
     }
 }

src/GitHub.Exports/ViewModels/IGitHubConnectSection.cs

@@ -8,8 +8,14 @@ public interface IGitHubConnectSection
         void DoCreate();
         void SignOut();
         void Login();
+        void Retry();
         bool OpenRepository();
+        string ErrorMessage { get; }
         IConnection SectionConnection { get; }
+        bool IsLoggingIn { get; }
+        bool ShowLogin { get; }
+        bool ShowLogout { get; }
+        bool ShowRetry { get; }
         ICommand Clone { get; }
     }
 }