Using named arguments to avoid changing argument order

StanleyGoldman · StanleyGoldman · commit 155481b4e191 · 2018-12-12T16:37:10.000-05:00
diff --git a/src/GitHub.App/Services/PullRequestService.cs b/src/GitHub.App/Services/PullRequestService.cs
@@ -90,7 +90,7 @@ public async Task<Page<PullRequestListItemModel>> ReadPullRequests(
                 if (readPullRequests == null)
                 {
                     readPullRequests = new Query()
-                          .Repository(Var(nameof(name)), Var(nameof(owner)))
+                          .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                           .PullRequests(
                               first: 100,
                               after: Var(nameof(after)),
@@ -151,7 +151,7 @@ public async Task<Page<PullRequestListItemModel>> ReadPullRequests(
                 if (readPullRequestsEnterprise == null)
                 {
                     readPullRequestsEnterprise = new Query()
-                          .Repository(Var(nameof(name)), Var(nameof(owner)))
+                          .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                           .PullRequests(
                               first: 100,
                               after: Var(nameof(after)),
@@ -292,7 +292,7 @@ public async Task<Page<ActorModel>> ReadAssignableUsers(
             if (readAssignableUsers == null)
             {
                 readAssignableUsers = new Query()
-                    .Repository(Var(nameof(name)), Var(nameof(owner)))
+                    .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                     .AssignableUsers(first: 100, after: Var(nameof(after)))
                     .Select(connection => new Page<ActorModel>
                     {
diff --git a/src/GitHub.App/Services/RepositoryCloneService.cs b/src/GitHub.App/Services/RepositoryCloneService.cs
@@ -100,7 +100,7 @@ public async Task<ViewerRepositoriesModel> ReadViewerRepositories(HostAddress ad
                         Organizations = viewer.Organizations(null, null, null, null).AllPages().Select(org => new
                         {
                             org.Login,
-                            Repositories = viewer.Repositories(null, null, null, null, null, null, null, order, null, null)
+                            Repositories = org.Repositories(null, null, null, null, null, null, null, order, null, null)
                                 .AllPages()
                                 .Select(repositorySelection).ToList()
                         }).ToDictionary(x => x.Login, x => (IReadOnlyList<RepositoryListItemModel>)x.Repositories),
diff --git a/src/GitHub.App/Services/RepositoryService.cs b/src/GitHub.App/Services/RepositoryService.cs
@@ -34,7 +34,7 @@ public RepositoryService(IGraphQLClientFactory graphqlFactory)
             if (readParentOwnerLogin == null)
             {
                 readParentOwnerLogin = new Query()
-                    .Repository(Var(nameof(name)), Var(nameof(owner)))
+                    .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                     .Select(r => r.Parent != null ? Tuple.Create(r.Parent.Owner.Login, r.Parent.Name) : null)
                     .Compile();
             }
diff --git a/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs b/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
@@ -292,7 +292,7 @@ public virtual async Task<PullRequestDetailModel> ReadPullRequestDetail(HostAddr
             if (readPullRequest == null)
             {
                 readPullRequest = new Query()
-                    .Repository(Var(nameof(name)), Var(nameof(owner)))
+                    .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                     .PullRequest(Var(nameof(number)))
                     .Select(pr => new PullRequestDetailModel
                     {
@@ -416,7 +416,7 @@ public async Task<string> GetGraphQLPullRequestId(
             var graphql = await graphqlFactory.CreateConnection(address);
 
             var query = new Query()
-                .Repository(localRepository.Name, repositoryOwner)
+                .Repository(owner: repositoryOwner, name: localRepository.Name)
                 .PullRequest(number)
                 .Select(x => x.Id);
 
@@ -781,7 +781,7 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres
                 if (readCommitStatuses == null)
                 {
                     readCommitStatuses = new Query()
-                          .Repository(Var(nameof(name)), Var(nameof(owner)))
+                          .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                           .PullRequest(Var(nameof(number))).Commits(last: 1).Nodes.Select(
                               commit => new LastCommitAdapter
                               {
@@ -833,7 +833,7 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres
                 if (readCommitStatusesEnterprise == null)
                 {
                     readCommitStatusesEnterprise = new Query()
-                     .Repository(Var(nameof(name)), Var(nameof(owner)))
+                     .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                      .PullRequest(Var(nameof(number))).Commits(last: 1).Nodes.Select(
                          commit => new LastCommitAdapter
                          {

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public async Task<ViewerRepositoriesModel> ReadViewerRepositories(HostAddress ad`
`100`	`100`	`Organizations = viewer.Organizations(null, null, null, null).AllPages().Select(org => new`
`101`	`101`	`{`
`102`	`102`	`org.Login,`
`103`		`- Repositories = viewer.Repositories(null, null, null, null, null, null, null, order, null, null)`
	`103`	`+ Repositories = org.Repositories(null, null, null, null, null, null, null, order, null, null)`
`104`	`104`	`.AllPages()`
`105`	`105`	`.Select(repositorySelection).ToList()`
`106`	`106`	`}).ToDictionary(x => x.Login, x => (IReadOnlyList<RepositoryListItemModel>)x.Repositories),`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public RepositoryService(IGraphQLClientFactory graphqlFactory)`
`34`	`34`	`if (readParentOwnerLogin == null)`
`35`	`35`	`{`
`36`	`36`	`readParentOwnerLogin = new Query()`
`37`		`- .Repository(Var(nameof(name)), Var(nameof(owner)))`
	`37`	`+ .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))`
`38`	`38`	`.Select(r => r.Parent != null ? Tuple.Create(r.Parent.Owner.Login, r.Parent.Name) : null)`
`39`	`39`	`.Compile();`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ public virtual async Task<PullRequestDetailModel> ReadPullRequestDetail(HostAddr`
`292`	`292`	`if (readPullRequest == null)`
`293`	`293`	`{`
`294`	`294`	`readPullRequest = new Query()`
`295`		`- .Repository(Var(nameof(name)), Var(nameof(owner)))`
	`295`	`+ .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))`
`296`	`296`	`.PullRequest(Var(nameof(number)))`
`297`	`297`	`.Select(pr => new PullRequestDetailModel`
`298`	`298`	`{`
`@@ -416,7 +416,7 @@ public async Task<string> GetGraphQLPullRequestId(`
`416`	`416`	`var graphql = await graphqlFactory.CreateConnection(address);`
`417`	`417`
`418`	`418`	`var query = new Query()`
`419`		`- .Repository(localRepository.Name, repositoryOwner)`
	`419`	`+ .Repository(owner: repositoryOwner, name: localRepository.Name)`
`420`	`420`	`.PullRequest(number)`
`421`	`421`	`.Select(x => x.Id);`
`422`	`422`
`@@ -781,7 +781,7 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres`
`781`	`781`	`if (readCommitStatuses == null)`
`782`	`782`	`{`
`783`	`783`	`readCommitStatuses = new Query()`
`784`		`- .Repository(Var(nameof(name)), Var(nameof(owner)))`
	`784`	`+ .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))`
`785`	`785`	`.PullRequest(Var(nameof(number))).Commits(last: 1).Nodes.Select(`
`786`	`786`	`commit => new LastCommitAdapter`
`787`	`787`	`{`
`@@ -833,7 +833,7 @@ async Task<LastCommitAdapter> GetPullRequestLastCommitAdapter(HostAddress addres`
`833`	`833`	`if (readCommitStatusesEnterprise == null)`
`834`	`834`	`{`
`835`	`835`	`readCommitStatusesEnterprise = new Query()`
`836`		`- .Repository(Var(nameof(name)), Var(nameof(owner)))`
	`836`	`+ .Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))`
`837`	`837`	`.PullRequest(Var(nameof(number))).Commits(last: 1).Nodes.Select(`
`838`	`838`	`commit => new LastCommitAdapter`
`839`	`839`	`{`