Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 1611cea

Browse files
authored
Merge pull request #348 from github/fixes/336-cancel-does-not-cancel
Always cancel the whole flow if a subflow is cancelled
2 parents ea329e6 + 98c674c commit 1611cea

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/GitHub.App/Controllers/UIController.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ void End(bool success)
601601
ShutdownFlow(activeFlow);
602602

603603
// if the auth was cancelled, we need to stop everything, otherwise we'll go into a loop
604-
if (activeFlow == mainFlow || (activeFlow == UIControllerFlow.Authentication && !Success.Value))
604+
if (activeFlow == mainFlow || !Success.Value)
605605
stopping = true;
606606

607607
Fire(Trigger.Next);

0 commit comments

Comments
 (0)