Refactor UsageTracker

Modified it to have independent Microsoft and GitHub metrics recording
methods. These methods will catch and log any exception with either
system.

Co-authored-by: Alex Panov <[email protected]>

Author: StanleyGoldman

src/GitHub.VisualStudio/Services/UsageTracker.cs

@@ -62,19 +62,44 @@ public async Task IncrementCounter(Expression<Func<UsageModel.MeasuresModel, int
             var propertyInfo = (PropertyInfo)property.Member;
             var eventName = propertyInfo.Name;
             log.Verbose("Increment counter {Name}", eventName);
-            var value = (int)propertyInfo.GetValue(usage.Measures);
-            propertyInfo.SetValue(usage.Measures, value + 1);
-            await service.WriteLocalData(data);
 
-            const string numberOfPrefix = "numberof";
-            if (eventName.IndexOf(numberOfPrefix, StringComparison.InvariantCultureIgnoreCase) != -1)
+            await ReportGitHubMetrics(propertyInfo, eventName, usage, data);
+
+            ReportMicrosoftTelemetry(eventName);
+        }
+
+        static void ReportMicrosoftTelemetry(string eventName)
+        {
+            try
+            {
+                const string numberOfPrefix = "numberof";
+                if (eventName.IndexOf(numberOfPrefix, StringComparison.InvariantCultureIgnoreCase) != -1)
+                {
+                    eventName = eventName.Substring(numberOfPrefix.Length);
+                }
+
+                var operation = new TelemetryEvent(EventNameBase + eventName);
+                operation.Properties[PropertyBase + TelemetryVersionProperty] = TelemetryVersion;
+                TelemetryService.DefaultSession.PostEvent(operation);
+            }
+            catch (Exception e)
             {
-                eventName = eventName.Substring(numberOfPrefix.Length);
+                log.Error(e, "Error recording Microsoft Telmetry");
             }
+        }
 
-            var operation = new OperationEvent(EventNameBase + eventName, TelemetryResult.Success);
-            operation.Properties[PropertyBase + TelemetryVersionProperty] = TelemetryVersion;
-            TelemetryService.DefaultSession.PostEvent(operation);
+        async Task ReportGitHubMetrics(PropertyInfo propertyInfo, string eventName, UsageModel usage, UsageData data)
+        {
+            try
+            {
+                var value = (int) propertyInfo.GetValue(usage.Measures);
+                propertyInfo.SetValue(usage.Measures, value + 1);
+                await service.WriteLocalData(data);
+            }
+            catch (Exception e)
+            {
+                log.Error(e, "Error recording GitHub Metrics");
+            }
         }
 
         IDisposable StartTimer()