Removed ConnectionManager.ConnectionCreated.

Author: grokys

src/GitHub.Exports/Services/IConnectionManager.cs

@@ -22,19 +22,6 @@ public interface IConnectionManager
         /// </remarks>
         IReadOnlyObservableCollection<IConnection> Connections { get; }
 
-        /// <summary>
-        /// Gets a callback that is called after a new <see cref="IConnection"/> is created but
-        /// before it is added to <see cref="Connections"/>.
-        /// </summary>
-        /// <remarks>
-        /// This is a hack and should be removed as soon as possible! It's needed because creating
-        /// a RepositoryHost is async meaning that for a short time a connection can exist without
-        /// a repository host, but other older parts of the code get confused by this. This callback
-        /// allows RepositoryHosts to hook into the creation of the connection to make sure a host
-        /// is available by the time the connection is made available.
-        /// </remarks>
-        Func<IConnection, Task> ConnectionCreated { get; set; }
-
         /// <summary>
         /// Gets a connection with the specified host address.
         /// </summary>

src/GitHub.VisualStudio/Services/ConnectionManager.cs

@@ -52,8 +52,6 @@ public ConnectionManager(
         /// <inheritdoc/>
         public IReadOnlyObservableCollection<IConnection> Connections => connections.Value;
 
-        public Func<IConnection, Task> ConnectionCreated { get; set; }
-
         /// <inheritdoc/>
         public async Task<IConnection> GetConnection(HostAddress address)
         {
@@ -80,11 +78,6 @@ public async Task<IConnection> LogIn(HostAddress address, string userName, strin
             var user = await loginManager.Login(address, client, userName, password);
             var connection = new Connection(address, userName, user, null);
 
-            if (ConnectionCreated != null)
-            {
-                await ConnectionCreated(connection);
-            }
-
             conns.Add(connection);
             await SaveConnections();
             await usageTracker.IncrementLoginCount();
@@ -150,11 +143,6 @@ async Task LoadConnections(ObservableCollection<IConnection> result)
 
                     var connection = new Connection(c.HostAddress, c.UserName, user, error);
 
-                    if (ConnectionCreated != null)
-                    {
-                        await ConnectionCreated(connection);
-                    }
-
                     result.Add(connection);
                     await usageTracker.IncrementLoginCount();
                 }