Add more functionality to SimpleRepositoryModel

Now that ActiveRepo is a SimpleRepositoryModel, we need a way to update
the url, for when a user adds or removes the origin remote manually
inside Visual Studio (in the git repo settings), or via the command
line.
This is required so that the UI updates properly and rechecks whether
the repo is ours or not.

Author: shana

src/GitHub.App/Extensions/RepositoryModelExtensions.cs

@@ -15,9 +15,7 @@ public static ISimpleRepositoryModel ToModel([AllowNull] this IGitRepositoryInfo
         {
             if (repo == null)
                 return null;
-            var uri = repo.GetUriFromRepository();
-            var name = uri?.NameWithOwner;
-            return name != null ? new SimpleRepositoryModel(name, uri, repo.RepositoryPath) : null;
+            return SimpleRepositoryModel.Create(repo.RepositoryPath);
         }
     }
 }

src/GitHub.App/SampleData/SampleViewModels.cs

@@ -388,7 +388,7 @@ public long PrivateReposInPlan
     }
 
     [ExcludeFromCodeCoverage]
-    public class RepositoryModelDesigner : IRepositoryModel
+    public class RepositoryModelDesigner : NotificationAwareObject, IRepositoryModel
     {
         public RepositoryModelDesigner() : this("repo")
         {
@@ -416,6 +416,8 @@ public void SetIcon(bool isPrivate, bool isFork)
         public Octicon Icon { get; set; }
 
         public IAccount Owner { get; set; }
+
+        public void Refresh() { }
     }
 
     public class RepositoryCloneViewModelDesigner : BaseViewModelDesigner, IRepositoryCloneViewModel

src/GitHub.Exports/Models/ISimpleRepositoryModel.cs

@@ -1,15 +1,22 @@
 using GitHub.Primitives;
 using GitHub.UI;
+using System.ComponentModel;
 
 namespace GitHub.Models
 {
-    public interface ISimpleRepositoryModel
+    public interface ISimpleRepositoryModel : INotifyPropertyChanged
     {
         string Name { get; }
         UriString CloneUrl { get; }
         string LocalPath { get; }
         Octicon Icon { get; }
 
         void SetIcon(bool isPrivate, bool isFork);
+
+
+        /// <summary>
+        /// Updates the url information based on the local path
+        /// </summary>
+        void Refresh();
     }
 }

src/GitHub.Exports/Models/SimpleRepositoryModel.cs

@@ -1,9 +1,11 @@
-using GitHub.Primitives;
+using GitHub.Extensions;
+using GitHub.Primitives;
 using GitHub.UI;
 using GitHub.VisualStudio.Helpers;
 using System;
 using System.Diagnostics;
 using System.Globalization;
+using System.IO;
 
 namespace GitHub.Models
 {
@@ -18,6 +20,31 @@ public SimpleRepositoryModel(string name, UriString cloneUrl, string localPath =
             Icon = Octicon.repo;
         }
 
+        public SimpleRepositoryModel(string path)
+        {
+            if (path == null)
+                throw new ArgumentNullException("path");
+            if (!Directory.Exists(path))
+                throw new ArgumentException("Path does not exist", path);
+            var uri = GitHelpers.GetRepoFromPath(path)?.GetUri();
+            var name = uri?.NameWithOwner;
+            if (name == null)
+                name = Path.GetDirectoryName(name);
+            Name = name;
+            LocalPath = path;
+            CloneUrl = uri;
+            Icon = Octicon.repo;
+        }
+
+        public static ISimpleRepositoryModel Create(string path)
+        {
+            if (path == null)
+                return null;
+            if (!Directory.Exists(path))
+                return null;
+            return new SimpleRepositoryModel(path);
+        }
+
         public void SetIcon(bool isPrivate, bool isFork)
         {
             Icon = isPrivate
@@ -27,15 +54,30 @@ public void SetIcon(bool isPrivate, bool isFork)
                         : Octicon.repo;
         }
 
+        public void Refresh()
+        {
+            if (LocalPath == null)
+                return;
+            var uri = GitHelpers.GetRepoFromPath(LocalPath)?.GetUri();
+            if (CloneUrl != uri)
+                CloneUrl = uri;
+        }
+
         public string Name { get; private set; }
-        public UriString CloneUrl { get; private set; }
+        UriString cloneUrl;
+        public UriString CloneUrl { get { return cloneUrl; } set { cloneUrl = value; this.RaisePropertyChange(); } }
         public string LocalPath { get; private set; }
         Octicon icon;
         public Octicon Icon { get { return icon; } set { icon = value; this.RaisePropertyChange(); } }
 
+        /// <summary>
+        /// Note: We don't consider CloneUrl a part of the hash code because it can change during the lifetime
+        /// of a repository. Equals takes care of any hash collisions because of this
+        /// </summary>
+        /// <returns></returns>
         public override int GetHashCode()
         {
-            return (Name?.GetHashCode() ?? 0) ^ (CloneUrl?.GetHashCode() ?? 0) ^ (LocalPath?.TrimEnd('\\').ToUpperInvariant().GetHashCode() ?? 0);
+            return (Name?.GetHashCode() ?? 0) ^ (LocalPath?.TrimEnd('\\').ToUpperInvariant().GetHashCode() ?? 0);
         }
 
         public override bool Equals(object obj)

src/GitHub.Exports/Services/VSServices.cs

@@ -117,16 +117,8 @@ static IEnumerable<ISimpleRepositoryModel> PokeTheRegistryForRepositoryList()
                 {
                     using (var subkey = key.OpenSubKey(x))
                     {
-                        var path = subkey?.GetValue("Path") as string;
-                        if (path != null)
-                        {
-                            var uri = VisualStudio.Services.GetRepoFromPath(path)?.GetUri();
-                            var name = uri?.NameWithOwner;
-                            if (name != null)
-                                return new SimpleRepositoryModel(name, uri, path);
-                        }
+                        return SimpleRepositoryModel.Create(subkey?.GetValue("Path") as string);
                     }
-                    return null;
                 })
                 .Where(x => x != null)
                 .ToList();