Throw when loading a page fails.

grokys · grokys · commit 1dbc9079e739 · 2018-07-11T14:55:01.000+02:00
`Task.WhenAny` doesn't not throw exceptions when one of the tasks it's awaiting throws. Need to do that manually.
diff --git a/src/GitHub.App/Collections/SequentialListSource.cs b/src/GitHub.App/Collections/SequentialListSource.cs
@@ -146,7 +146,12 @@ async Task<Page<TModel>> EnsureLoaded(int pageNumber)
                     }
                 }
 
-                await Task.WhenAny(loading, pageLoaded).ConfigureAwait(false);
+                var completed = await Task.WhenAny(loading, pageLoaded).ConfigureAwait(false);
+
+                if (completed.IsFaulted)
+                {
+                    throw completed.Exception;
+                }
 
                 if (pageLoaded.IsCompleted)
                 {

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,12 @@ async Task<Page<TModel>> EnsureLoaded(int pageNumber)`
`146`	`146`	`}`
`147`	`147`	`}`
`148`	`148`
`149`		`- await Task.WhenAny(loading, pageLoaded).ConfigureAwait(false);`
	`149`	`+ var completed = await Task.WhenAny(loading, pageLoaded).ConfigureAwait(false);`
	`150`	`+`
	`151`	`+ if (completed.IsFaulted)`
	`152`	`+ {`
	`153`	`+ throw completed.Exception;`
	`154`	`+ }`
`150`	`155`
`151`	`156`	`if (pageLoaded.IsCompleted)`
`152`	`157`	`{`