Fixing tests that compare users by setting the login

Author: StanleyGoldman

test/GitHub.InlineReviews.UnitTests/ViewModels/PullRequestReviewCommentViewModelTests.cs

@@ -51,12 +51,11 @@ public void CanBeExecutedForCommentsByTheSameAuthor()
                 var thread = CreateThread();
 
                 var currentUser = Substitute.For<IAccount>();
+                currentUser.Login.Returns("CurrentUser");
 
                 var pullRequestReviewCommentModel = Substitute.For<IPullRequestReviewCommentModel>();
                 pullRequestReviewCommentModel.User.Returns(currentUser);
 
-                currentUser.Equals(Arg.Is(currentUser)).Returns(true);
-
                 var target = CreateTarget(session, thread, currentUser, pullRequestReviewCommentModel);
                 Assert.That(target.BeginCreate.CanExecute(new object()), Is.True);
             }
@@ -68,13 +67,14 @@ public void CannotBeExecutedForCommentsByAnotherAuthor()
                 var thread = CreateThread();
 
                 var currentUser = Substitute.For<IAccount>();
+                currentUser.Login.Returns("CurrentUser");
+
                 var otherUser = Substitute.For<IAccount>();
+                currentUser.Login.Returns("OtherUser");
 
                 var pullRequestReviewCommentModel = Substitute.For<IPullRequestReviewCommentModel>();
                 pullRequestReviewCommentModel.User.Returns(otherUser);
 
-                currentUser.Equals(Arg.Is(otherUser)).Returns(false);
-
                 var target = CreateTarget(session, thread, currentUser, pullRequestReviewCommentModel);
                 Assert.That(target.BeginCreate.CanExecute(new object()), Is.False);
             }
@@ -99,12 +99,11 @@ public void CanBeExecutedForCommentsByTheSameAuthor()
                 var thread = CreateThread();
 
                 var currentUser = Substitute.For<IAccount>();
+                currentUser.Login.Returns("CurrentUser");
 
                 var pullRequestReviewCommentModel = Substitute.For<IPullRequestReviewCommentModel>();
                 pullRequestReviewCommentModel.User.Returns(currentUser);
 
-                currentUser.Equals(Arg.Is(currentUser)).Returns(true);
-
                 var target = CreateTarget(session, thread, currentUser, pullRequestReviewCommentModel);
                 Assert.That(target.Delete.CanExecute(new object()), Is.True);
             }
@@ -116,13 +115,14 @@ public void CannotBeExecutedForCommentsByAnotherAuthor()
                 var thread = CreateThread();
 
                 var currentUser = Substitute.For<IAccount>();
+                currentUser.Login.Returns("CurrentUser");
+
                 var otherUser = Substitute.For<IAccount>();
+                currentUser.Login.Returns("OtherUser");
 
                 var pullRequestReviewCommentModel = Substitute.For<IPullRequestReviewCommentModel>();
                 pullRequestReviewCommentModel.User.Returns(otherUser);
 
-                currentUser.Equals(Arg.Is(otherUser)).Returns(false);
-
                 var target = CreateTarget(session, thread, currentUser, pullRequestReviewCommentModel);
                 Assert.That(target.Delete.CanExecute(new object()), Is.False);
             }