Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 2311757

Browse files
committed
Theme tab control border
Remove unused color brushes
1 parent 92f25dd commit 2311757

File tree

5 files changed

+6
-15
lines changed

5 files changed

+6
-15
lines changed

src/GitHub.VisualStudio/Styles/ThemeBlue.xaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@
1919
<Color x:Key="GitHubPaneTitleColor">#FF1B293E</Color>
2020
<SolidColorBrush x:Key="GitHubPaneTitleBrush" Color="{StaticResource GitHubPaneTitleColor}" />
2121

22-
<SolidColorBrush x:Key="GitHubTabItemSelectedBackground" Color="#FFFFFF"/>
23-
<SolidColorBrush x:Key="GitHubTabItemSelectedBorder" Color="#ACACAC"/>
24-
2522
<SolidColorBrush x:Key="GitHubPrimaryGreenBrush" Color="#FF6CC644" />
2623
<SolidColorBrush x:Key="GitHubPrimaryOrangeBrush" Color="#FFC9510C" />
2724

src/GitHub.VisualStudio/Styles/ThemeDark.xaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@
1919
<Color x:Key="GitHubPaneTitleColor">#FFFFFFFF</Color>
2020
<SolidColorBrush x:Key="GitHubPaneTitleBrush" Color="{StaticResource GitHubPaneTitleColor}" />
2121

22-
<SolidColorBrush x:Key="GitHubTabItemSelectedBackground" Color="#000000"/>
23-
<SolidColorBrush x:Key="GitHubTabItemSelectedBorder" Color="#ACACAC"/>
24-
2522
<SolidColorBrush x:Key="GitHubPrimaryGreenBrush" Color="#FF6CC644" />
2623
<SolidColorBrush x:Key="GitHubPrimaryOrangeBrush" Color="#FFC9510C" />
2724

src/GitHub.VisualStudio/Styles/ThemeDesignTime.xaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@
44
xmlns:PresentationOptions="http://schemas.microsoft.com/winfx/2006/xaml/presentation/options">
55

66
<ResourceDictionary.MergedDictionaries>
7-
<ResourceDictionary Source="pack://application:,,,/GitHub.VisualStudio;component/Styles/ThemeBlue.xaml" />
7+
<ResourceDictionary Source="pack://application:,,,/GitHub.VisualStudio;component/Styles/ThemeDark.xaml" />
88
</ResourceDictionary.MergedDictionaries>
99

1010
<!-- Design time colors taken from the VS dark theme
11+
-->
1112
<SolidColorBrush x:Key="GitHubVsToolWindowText" Color="#FFFFFFFF" />
1213
<SolidColorBrush x:Key="GitHubVsToolWindowBackground" Color="#FF252526" />
1314
<SolidColorBrush x:Key="GitHubVsGrayText" Color="#FF999999" />
@@ -16,7 +17,6 @@
1617
<SolidColorBrush x:Key="GitHubVsSearchBoxBackground" Color="#FF333337" />
1718
<SolidColorBrush x:Key="GitHubVsWindowText" Color="#FFF1F1F1" />
1819
<SolidColorBrush x:Key="GitHubVsBrandedUIBorder" Color="#FF3F3F46" />
19-
-->
2020

2121
<!-- Design time colors taken from the VS light theme
2222
<SolidColorBrush x:Key="GitHubVsToolWindowText" Color="#FF1E1E1E" />
@@ -31,7 +31,6 @@
3131
-->
3232

3333
<!-- Design time colors taken from the VS blue theme
34-
-->
3534
<SolidColorBrush x:Key="GitHubVsToolWindowText" Color="#FF000000" />
3635
<SolidColorBrush x:Key="GitHubVsToolWindowBackground" Color="#FFFFFFFF" />
3736
<SolidColorBrush x:Key="GitHubVsGrayText" Color="#FF6d6d6d" />
@@ -41,4 +40,5 @@
4140
<SolidColorBrush x:Key="GitHubVsWindowText" Color="#FF000000" />
4241
<SolidColorBrush x:Key="GitHubVsBrandedUIBorder" Color="#FF8591A2" />
4342
<SolidColorBrush x:Key="GitHubVsBrandedUIBackground" Color="#FFFFFFFF" />
43+
-->
4444
</ResourceDictionary>

src/GitHub.VisualStudio/Styles/ThemeLight.xaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@
1919
<Color x:Key="GitHubPaneTitleColor">#FF1B293E</Color>
2020
<SolidColorBrush x:Key="GitHubPaneTitleBrush" Color="{StaticResource GitHubPaneTitleColor}" />
2121

22-
<SolidColorBrush x:Key="GitHubTabItemSelectedBackground" Color="#FFFFFF"/>
23-
<SolidColorBrush x:Key="GitHubTabItemSelectedBorder" Color="#ACACAC"/>
24-
2522
<SolidColorBrush x:Key="GitHubPrimaryGreenBrush" Color="#FF6CC644" />
2623
<SolidColorBrush x:Key="GitHubPrimaryOrangeBrush" Color="#FFC9510C" />
2724

src/GitHub.VisualStudio/UI/Views/PullRequestCreationView.xaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<Setter Property="HorizontalContentAlignment" Value="Center"/>
3636
<Setter Property="VerticalContentAlignment" Value="Center"/>
3737
<Setter Property="Background" Value="{DynamicResource GitHubVsToolWindowBackground}"/>
38-
<Setter Property="BorderBrush" Value="#FFD0D7E4"/>
38+
<Setter Property="BorderBrush" Value="{DynamicResource GitHubVsBrandedUIBorder}"/>
3939
<Setter Property="BorderThickness" Value="0,1,0,0"/>
4040
<Setter Property="Foreground" Value="{DynamicResource {x:Static SystemColors.ControlTextBrushKey}}"/>
4141
<Setter Property="Template">
@@ -109,15 +109,15 @@
109109
x:Name="ContentSite"
110110
FontSize="12"
111111
VerticalAlignment="Center"
112-
Foreground="#ff333333"
112+
Foreground="{DynamicResource GitHubVsToolWindowText}"
113113
Text="{TemplateBinding Header}" />
114114
</DockPanel>
115115
</Border>
116116

117117
<ControlTemplate.Triggers>
118118
<Trigger Property="IsSelected" Value="True">
119119
<Setter TargetName="Border" Property="Background" Value="{DynamicResource GitHubVsToolWindowBackground}" />
120-
<Setter TargetName="Border" Property="BorderBrush" Value="#ffD0D7E4" />
120+
<Setter TargetName="Border" Property="BorderBrush" Value="{DynamicResource GitHubVsBrandedUIBorder}" />
121121
<Setter TargetName="Border" Property="BorderThickness" Value="1,1,1,0" />
122122
</Trigger>
123123

0 commit comments

Comments
 (0)