Listen to all relevant notifications

There's two types of notifications that can come up via the Publish
viewmodel: warnings from validators while filling out the form, and
errors from the publish process. Errors are sent via the notification
system, and warnings come up via the validators.

We're doing it like this for now because warnings are reactive based on
user input (so they go away if the validator becomes valid), and I'm
still not sure if the NotificationDispatcher should have a
`ClearNotifications` method (it's just dispatching messages, is it its
job to invalidate messages too? unsure)

Author: shana

src/GitHub.VisualStudio/Resources.Designer.cs

@@ -279,4 +279,7 @@
   <data name="NotLoggedInMessage" xml:space="preserve">
     <value>You are not logged in to {0}, so certain git operations may fail. [Login now]({1})</value>
   </data>
+  <data name="RepositoryPublishedMessage" xml:space="preserve">
+    <value>Repository created successfully.</value>
+  </data>
 </root>

src/GitHub.VisualStudio/Resources.resx

@@ -22,7 +22,7 @@ public class GenericRepositoryPublishControl : SimpleViewUserControl<IRepository
     public partial class RepositoryPublishControl : GenericRepositoryPublishControl
     {
         [ImportingConstructor]
-        public RepositoryPublishControl(ITeamExplorerServices teServices)
+        public RepositoryPublishControl(ITeamExplorerServices teServices, INotificationDispatcher notifications)
         {
             InitializeComponent();
 
@@ -33,7 +33,7 @@ public RepositoryPublishControl(ITeamExplorerServices teServices)
                 d(this.Bind(ViewModel, vm => vm.SelectedConnection, v => v.hostsComboBox.SelectedItem));
 
                 d(this.Bind(ViewModel, vm => vm.RepositoryName, v => v.nameText.Text));
-                
+
                 d(this.Bind(ViewModel, vm => vm.Description, v => v.description.Text));
                 d(this.Bind(ViewModel, vm => vm.KeepPrivate, v => v.makePrivate.IsChecked));
                 d(this.OneWayBind(ViewModel, vm => vm.CanKeepPrivate, v => v.makePrivate.IsEnabled));
@@ -50,18 +50,26 @@ public RepositoryPublishControl(ITeamExplorerServices teServices)
                 ViewModel.PublishRepository.Subscribe(state =>
                 {
                     if (state == ProgressState.Success)
+                    {
+                        teServices.ShowMessage(VisualStudio.Resources.RepositoryPublishedMessage);
                         NotifyDone();
+                    }
                 });
 
                 d(this.WhenAny(x => x.ViewModel.IsPublishing, x => x.Value)
                     .Subscribe(x => NotifyIsBusy(x)));
 
+
+                d(notifications.Listen()
+                    .Where(n => n.Type == Notification.NotificationType.Error)
+                    .Subscribe(n => teServices.ShowError(n.Message)));
+
                 d(this.WhenAny(x => x.ViewModel.SafeRepositoryNameWarningValidator.ValidationResult, x => x.Value)
                     .WhereNotNull()
                     .Select(result => result?.Message)
                     .Subscribe(message =>
                     {
-                        if (!string.IsNullOrEmpty(message))
+                        if (!String.IsNullOrEmpty(message))
                             teServices.ShowWarning(message);
                         else
                             teServices.ClearNotifications();