Changing UsageModel back to a class

Author: StanleyGoldman

src/GitHub.Exports/Models/UsageModel.cs

@@ -2,14 +2,8 @@
 
 namespace GitHub.Models
 {
-    [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1815:OverrideEqualsAndOperatorEqualsOnValueTypes", Justification = "It'll use reflection by default and we're fine with that")]
-    public struct UsageModel
+    public class UsageModel
     {
-        public static UsageModel Default = new UsageModel
-        {
-            Guid = Guid.Empty
-        };
-
         public Guid Guid { get; set; }
         public DateTimeOffset Date { get; set; }
         public string AppVersion { get; set; }

src/GitHub.VisualStudio/Services/UsageTracker.cs

@@ -48,17 +48,12 @@ public async Task IncrementCounter(Expression<Func<UsageModel, int>> counter)
             await Initialize();
             var data = await service.ReadLocalData();
             var usage = await GetCurrentReport(data);
-            // because Model is a struct, it needs to be boxed in order for reflection to work
-            object model = usage;
             var property = (MemberExpression)counter.Body;
             var propertyInfo = (PropertyInfo)property.Member;
             log.Verbose("Increment counter {Name}", propertyInfo.Name);
-            var value = (int)propertyInfo.GetValue(model);
-            propertyInfo.SetValue(model, value + 1);
-
-            //TODO:  Understand changes here
-            //usage.Model = (UsageModel)model;
-            //await service.WriteLocalData(data);
+            var value = (int)propertyInfo.GetValue(usage);
+            propertyInfo.SetValue(usage, value + 1);
+            await service.WriteLocalData(data);
         }
 
         IDisposable StartTimer()
@@ -131,7 +126,7 @@ async Task<UsageModel> GetCurrentReport(UsageData data)
         {
             var current = data.Reports.FirstOrDefault(x => x.Date.Date == DateTimeOffset.Now.Date);
 
-            if (current.Equals(UsageModel.Default))
+            if (current == null)
             {
                 var guid = await service.GetUserGuid();
                 current = UsageModel.Create(guid);